You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2006/10/06 14:32:37 UTC

DO NOT REPLY [Bug 40694] New: - Image gets moved into another area even if there is space

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40694>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40694

           Summary: Image gets moved into another area even if there is
                    space
           Product: Fop
           Version: 0.20.5
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P4
         Component: page-master/layout
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: denismo@yahoo.com


Sorry, can't provide test at this moment - need to filter out proprietary
information.

But, if you look at the code of ExternalGraphics and Area, you may notice the
following:

// We estimate the space left in the area

            if (area.spaceLeft() < (height + spaceBefore)) {
                return Status.AREA_FULL_NONE;
            }

// ... blah

// We modify the space left in the area (addDisplaySpace changes
Area.currentHeight, and spaceLeft uses currentHeight)
            if ((spaceBefore != 0) && (this.marker == 0)) {
                area.addDisplaySpace(spaceBefore);
            }

// ... blah

// We modify the space left in the area 
            if (spaceAfter != 0) {
                area.addDisplaySpace(spaceAfter);
            }

// We use the space left in the area, but AFTER the modifications above
            if (breakBefore == BreakBefore.PAGE
                    || ((spaceBefore + imageArea.getHeight())
                        > area.spaceLeft())) {
                return Status.FORCE_PAGE_BREAK;
            }


The result is - sometimes image doesn't fit.  Reading spaceLeft into a variable
before modification and using the variable in the remaining places fixed the
problem, for me at least.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

DO NOT REPLY [Bug 40694] - Image gets moved into another area even if there is space

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40694>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40694


bowditch_chris@hotmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX




------- Additional Comments From bowditch_chris@hotmail.com  2006-10-09 02:19 -------
Fop 0.20.x is no longer supported. Please retest your sample with FOP 
0.92beta. Feel free to re-open the bug if your test fails on 0.92beta.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.