[GitHub] [rocketmq] Jason918 commented on a change in pull request #3357: RIP-7 Multiple Directories Storage Support

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #3357:
URL: https://github.com/apache/rocketmq/pull/3357#discussion_r712892164



##########
File path: store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java
##########
@@ -17,10 +17,14 @@
 package org.apache.rocketmq.store.config;
 
 import java.io.File;
+
 import org.apache.rocketmq.common.annotation.ImportantField;
 import org.apache.rocketmq.store.ConsumeQueue;
 
 public class MessageStoreConfig {
+
+    public static final String MULTI_PATH_SPLITTER = ":";

Review comment:
       YES, it would be confusing. Thank you for the reminding.
   A common reserved character would be a nice fit for this splitter.
   According to[ Comparison of file Systems](https://en.wikipedia.org/wiki/Comparison_of_file_systems), different files system have different reserved characters. So there is no best character for this splitter,  and I am using ',' as default splitter, user can change it using system property `rocketmq.broker.multiPathSplitter`
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org