You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/02/22 09:08:42 UTC

[GitHub] [avro] anekdoti opened a new pull request #1101: Added unit test for decoding of strings with length > 256

anekdoti opened a new pull request #1101:
URL: https://github.com/apache/avro/pull/1101

Make sure you have checked _all_ steps below.

### Jira

- [x ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3005
- https://github.com/apache/avro/pull/1013
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).

### Tests

- [x ] My PR only adds a test case to check decoding of strings of length > 256 (which was fixed by https://github.com/apache/avro/pull/1013)

### Commits

- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"

### Documentation

- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- No new functionality added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #1101: Added unit test for decoding of strings with length > 256

Posted by GitBox <gi...@apache.org>.

RyanSkraba commented on pull request #1101:
URL: https://github.com/apache/avro/pull/1101#issuecomment-784367866


   Thanks for the contribution!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #1101: Added unit test for decoding of strings with length > 256

Posted by GitBox <gi...@apache.org>.

RyanSkraba merged pull request #1101:
URL: https://github.com/apache/avro/pull/1101


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org