You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2010/01/16 13:14:43 UTC
[jira] Created: (CAMEL-2371) Netty component
Netty component
---------------
Key: CAMEL-2371
URL: https://issues.apache.org/activemq/browse/CAMEL-2371
Project: Apache Camel
Issue Type: New Feature
Reporter: Claus Ibsen
Fix For: Future
Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work stopped: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-2371 stopped by Ashwin Karpe.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58350#action_58350 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
*NettyConsumer*
- The INFO logging has a bit of space and colon cosmetic issue
- The source parameter for creating thread pool from Camel should be {{this}} and not {{null}}
- Why is the UDP mode using a CachedThreadPool and not using size/maxSize from configuration as with TCP?
- The thread pool name is too long, as it should just be like: {{NettyTCPBoss}} or {{NettyTCPWorker}} etc. Camel will add more details to the thread name as well.
*ClientChannelHandler*
- I wonder if just logging the Exception is enough? And when logging you should add the exception as 2nd parameter so we got the stacktrace also
*ServerChannelHandler*
- The WARN logging may have some English wording issue.
*Producer/Consumer*
- In the doStart you init either UDP or TCP. I think the if should be an if else to make this more strong. Having a {{return}} is not nice.
- Doesn't the await method on {{countdownLatch.await}} return a boolean if the timeout triggered, if so please use that instead of checking for == 1 as you currently do.
- I think the bufferSizes should be configurable as well, currently they are hardcoded
*General*
- Please check methods as some have empty lines in it, and there are like double lines between methods. Just to keep the code nice and clean
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip, camel-netty20100316.diff, camel-netty20100316.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: camel-netty20100304.zip
camel-netty-patch.diff
Hi Hadrian Claus and Jon,
I have developed the camel netty component and I am making it available for your thoughts and comment.
The component supports TCP, UDP and SSL in both sync/async modes. The only difference camel-netty has with regard to Mina is that it does not send Exchanges themselves over the wire. It does support byte arrays for non-serializable payloads and serializable payloads/objects (including strings).
I have added about 7 tests with different scenarios and performed checkstyle verification.
I will commit the component and add documentation as soon as I incorporate any thoughts, comments or ideas you may have.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: camel-netty20100324.zip
camel-netty20100324.diff
Hi Claus,
I have made the fixes you suggested and have uploaded a patch file and the camel netty zip file containing the source code for the component.
Can you let me know if I can go ahead and commit this version of the component. I will than go ahead write up the documentation for the component.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip, camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe resolved CAMEL-2371.
---------------------------------
Resolution: Fixed
Committed initial version as revision r927700
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58443#action_58443 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Cool.
I could on find a missing space in these INFO logs, which there are in multiple source files
{code}
LOG.info("Netty TCP Consumer started and now listening on Host: " + configuration.getHost() + "Port: " + configuration.getPort());
{code}
Notice there is no space before {{Port:}}
And in this code
{code}
if (!future.isSuccess()) {
+ throw new CamelExchangeException("Could not send response via Channel", exchange);
+ }
{code}
Maybe you can dig more info from Netty's {{MessageEvent}} so you can add more details to the exception. For example the host:port where you was trying to write etc.
And is the {{clean}} plugin needed in the {{pom.xml}} file? Maybe you copied it from camel-ftp which uses it?
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: (was: camel-netty20100316.zip)
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: (was: camel-netty20100316.diff)
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58042#action_58042 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
In this code
{code}
+ try {
+ consumer.getProcessor().process(exchange);
+ } catch (Exception exception) {
+ throw new Exception("Error in consumer while dispatching exchange for further processing", exception);
+ }
{code{
Its best to throw a CamelExchangeException since the exception occurred while processing that exchange.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58278#action_58278 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Ashwin.
I actually think we need to consult Netty documentation what they recommend to provide as {{ExeuctorService}} (= thread pool).
The cached executor service provided from the JDK is too aggressive IMHO, eg. you can end up with 1000s created threads in no time, if the server is not busy.
So I would assume they had a pool setting with like a min / max value. For example Jetty is using 20 / 200 AFAIR.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58300#action_58300 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Claus,
I have made the threadPoolSize (core/max) a config setting so that it can be influenced as needed. I have set them to 10/100 for the producer and same for the consumer, by default.
I did not find any guidance on the Netty site for the optimal combination....
Also, I added a JBoss repository to the camel-netty component pom.xml (based on WIllem's recommedation) so that the Netty version could be downloaded. I am not sure if this is the best place or whether I should add the repository to parent/pom.xml.
Ideally, the netty jars could be stored in the apache repository. Not sure of policies here but netty has a Apache 2.0 license. Do you have any guidance in this regard?
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip, camel-netty20100316.diff, camel-netty20100316.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58444#action_58444 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
I think if you get those last remarks fixed then +1 to commit it to Apache
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: camel-netty20100325.zip
camel-netty20100325.diff
Hi Claus,
Please find the attached patch and zip files containing the changes you recommended. I will check-in this version if you approve...
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58273#action_58273 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Sure thing... I will change the threadpool to be created using CamelContext.getExecutorService().newCachedExecutorService()
Cheers,
Ashwin...
P.S: Looks like my email sent the out of office message as a reply to your comment. I have disabled it now :). Not sure how to delete my comment though..
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58029#action_58029 ]
Willem Jiang commented on CAMEL-2371:
-------------------------------------
@Ashwin
I just have quick look of you patch, it looks good, you ready implemented the tcp and udp transport by leverage netty.
Do you have any plan to add other transport (such as local, xnio) etc implementation ?
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58258#action_58258 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Ashwin
Its recommended to use {{CamelContext.getExecutorService().newCachedExecutorService()}} or the appropriate create method.
Then its ensured that proper shutdown of the pool will be handled as CamelContext will shutdown created pools when its shutdown.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: (was: camel-netty-patch.diff)
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58042#action_58042 ]
Claus Ibsen edited comment on CAMEL-2371 at 3/4/10 4:42 PM:
------------------------------------------------------------
In this code
{code}
+ try {
+ consumer.getProcessor().process(exchange);
+ } catch (Exception exception) {
+ throw new Exception("Error in consumer while dispatching exchange for further processing", exception);
+ }
{code}
Its best to throw a CamelExchangeException since the exception occurred while processing that exchange.
was (Author: davsclaus):
In this code
{code}
+ try {
+ consumer.getProcessor().process(exchange);
+ } catch (Exception exception) {
+ throw new Exception("Error in consumer while dispatching exchange for further processing", exception);
+ }
{code{
Its best to throw a CamelExchangeException since the exception occurred while processing that exchange.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58465#action_58465 ]
Ashwin Karpe edited comment on CAMEL-2371 at 3/26/10 4:37 AM:
--------------------------------------------------------------
Hi Claus,
Please find the attached patch and zip files containing the changes you recommended. I will check-in this version...
Cheers,
Ashwin...
was (Author: akarpe):
Hi Claus,
Please find the attached patch and zip files containing the changes you recommended. I will check-in this version if you approve...
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58447#action_58447 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Sure, no problem. I will fix these and then commit to Apache.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58030#action_58030 ]
Willem Jiang commented on CAMEL-2371:
-------------------------------------
Just another quick note of the camel-netty pom.xml,
You need to add the netty maven repo, and the declaration of netty-version property.
In this way, we can build the camel-netty without any complain.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58041#action_58041 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Cool work, just a few comments
You pass in a thread pool to Netty in NettyConsumer
{code}
new NioServerSocketChannelFactory(Executors.newCachedThreadPool(), Executors.newCachedThreadPool());
{code}
You can use the org.apache.camel.util.ExecutorServices which offer a newCachedThreadPool where you can pass in a thread name.
This is good to use as then the threads will be prefixed with Camel and a counter which ensures that end users can know its from Camel.
You can etc. use the endpointUri as the thread name
Btw in your unit tests you can avoid ugly type casting and pass in the type as 2nd parameter.
{code}
String reply requestBody("direct:foo", "hello", String.class);
{code}
Maybe you can add a little DEBUG or INFO logging when the consumer starts so it logs which host:port it starts to listen.
What does this annotation do?
{code}
+@ChannelPipelineCoverage("all")
{code}
And in the exceptionCaught method its debugged that the channel is closed, but there is no code that does this, is this correct?
In ServerChannelHandler you convert the payload from byte[] -> String if DEBUG logging is enable. If DEBUG is not enable you do NOT convert. This is wrong.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58486#action_58486 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Hi Claus,
Looks like Willem got to this before I did. I believe this should be fixed now.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2371:
-------------------------------
Fix Version/s: (was: Future)
2.3.0
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-2371 started by Ashwin Karpe.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: camel-netty20100316.zip
camel-netty20100316.diff
Hi Claus & Willem,
I have incorporated all your recommendations. Can you please take a look and let me know what you think.
I have also added a concurrency test that will exercise concurrent producers against a netty consumer.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip, camel-netty20100316.diff, camel-netty20100316.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58256#action_58256 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Claus,
I checked org.apache.camel.spi.ExecutorServiceStrategy. It is an interface. If I have to use it, I will need to implement a separate class to implement the methods to create the pool etc.
I found org.apache.camel.util.concurrent.ExecutorServiceHelper api to create a newThread pool more convenient and am currently using it. It is more in in line with your prior recommendation a few comments above... Please let me know if this is not appropriate.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58491#action_58491 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
We need a feature for this new component so its easy to install in OSGi
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58033#action_58033 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Hi Willem,
Thanks for rightly identifying the netty maven repo site in the repository. I do need to do it. As for the netty version I uses 3.1.5-GA which is fully APL 2.0 licensed. APL license is effective as of 3.1.3-GA.
I will look into local and xnio support in Netty. I have not looked at this closely. I will add it via a separate enhancement and link it to this issue.
Thanks for the feedback.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58043#action_58043 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
When you add custom headers use the Camel case syntax
eg
{code}
exchange.getIn().setHeader("CHANNEL_HANDLER_CONTEXT", ctx);
+ exchange.getIn().setHeader("MESSAGE_EVENT", messageEvent);
{code}
Should be
{code}
exchange.getIn().setHeader("CamelNettyChannelHandlerContext", ctx);
+ exchange.getIn().setHeader("CamelNettyMessageEvent", messageEvent);
{code}
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58070#action_58070 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Just a quick note, on trunk, there is a now a {{org.apache.camel.spil.ExecutorServiceStrategy}} which you get from {{CamelContext}}. It has methods to create thread pools you need to pass to Netty.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe updated CAMEL-2371:
--------------------------------
Attachment: (was: camel-netty20100304.zip)
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58306#action_58306 ]
Hadrian Zbarcea commented on CAMEL-2371:
----------------------------------------
Ashwin, yes, it's all right to put it there. I prefer not putting it in the parent pom, as it will be hit for all the other components as well.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip, camel-netty20100316.diff, camel-netty20100316.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58441#action_58441 ]
Ashwin Karpe edited comment on CAMEL-2371 at 3/25/10 2:11 AM:
--------------------------------------------------------------
Hi Claus,
I have made the fixes you suggested and have uploaded a patch file and the camel netty zip file containing the source code for the component.
Can you let me know if I can go ahead and commit this version of the component. I will go ahead and write up the documentation for the component following your go-ahead.
Cheers,
Ashwin...
was (Author: akarpe):
Hi Claus,
I have made the fixes you suggested and have uploaded a patch file and the camel netty zip file containing the source code for the component.
Can you let me know if I can go ahead and commit this version of the component. I will than go ahead write up the documentation for the component.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff, camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58048#action_58048 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Hi Claus,
Thanks for the feedback. I will work on the changes you suggested and submit the next iteration for your review and comment.
I will try to get it done by this weekend. I am on a customer gig all day tomorrow and proceed on vacation all of next week and may not be able to get a chance to work on it. In the event I cannot get it done this weekend, please bear with me. I will try and submit it early the week following.
As for the annotation ***@ChannelPipelineCoverage("all")*** it simply means that the same handler may be applied against multiple channel pipeline instances. The only options available are "one" and "all". The choice of "one" will force creation of individual handler instances per pipeline.
The exceptionCaught() debug statement stating that the channel is closed but the fact that it is not is a glitch. I need to rework the debug statement (possibly even remove the method and fall back on default handling). Channel closure is not essential since there are some cases where exceptions caught are not fatal in nature.
I will make the countdownLatch local and check out ServicePoolAware. That is a good catch. I did not pick up on this implication during development. Thanks.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58467#action_58467 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Ashwin can you add the JBoss Repo where the Netty JAR is located to the pom.xml of camel-netty.
It's now downloaded right now
{code}
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to resolve artifact.
Missing:
----------
1) org.jboss.netty:netty:jar:3.1.5.GA
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=org.jboss.netty -DartifactId=netty -Dversion=3.1.5.GA -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=org.jboss.netty -DartifactId=netty -Dversion=3.1.5.GA -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.apache.camel:camel-netty:bundle:2.3-SNAPSHOT
2) org.jboss.netty:netty:jar:3.1.5.GA
----------
1 required artifact is missing.
for artifact:
org.apache.camel:camel-netty:bundle:2.3-SNAPSHOT
from the specified remote repositories:
apache.snapshots (http://repository.apache.org/snapshots),
Nexus (http://localhost:8081/nexus/content/groups/public),
{code}
PS: My nexus is just a cache for the usual central Maven repo
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58527#action_58527 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Ashwin do you mind get started on wiki documentation for this new component?
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: 2.3.0
>
> Attachments: camel-netty20100324.diff, camel-netty20100324.zip, camel-netty20100325.diff, camel-netty20100325.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashwin Karpe reassigned CAMEL-2371:
-----------------------------------
Assignee: Ashwin Karpe
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58257#action_58257 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
I am currently on vacation from 03/08/10 thru 03/12/10. I should be back online on 03/15/10. In the meantime, in case of urgent support requests please connect with my manager Wolfgang Schulze for him to identify and allocate a suitable backup. Thanks and Regards, Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Ashwin Karpe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58255#action_58255 ]
Ashwin Karpe commented on CAMEL-2371:
-------------------------------------
Hi Claus,
I have started making the necessary changes to the Netty component based on your feedback.
Cheers,
Ashwin...
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58044#action_58044 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
The NettyProducer cannot be shared between multiple threads as you got a shared countdown latch. Maybe its possible to avoid this and have a local latch.
So it must like Mina be a pooled resource, so ensure its also ServicePoolAware or whatever that interface was named. Eg take a look at Mina or FTP as they are as well.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2371) Netty component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58053#action_58053 ]
Claus Ibsen commented on CAMEL-2371:
------------------------------------
Hi Ashwin
No rush, Camel 2.3 is still in 2-3 months development.
Thanks for the explanation of the Netty ChannelPipelineCoverage annotation.
I suggest you copy the MinaConcurrentTests which tests how it works with concurrent requests/responses. That should help you to ensure that it all works okay in those situations as well.
Especially with request/reply and that latch thingy.
> Netty component
> ---------------
>
> Key: CAMEL-2371
> URL: https://issues.apache.org/activemq/browse/CAMEL-2371
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Claus Ibsen
> Assignee: Ashwin Karpe
> Fix For: Future
>
> Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still not released.
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It appears as a good alternative.
> Netty is also Apache licensed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.