You are viewing a plain text version of this content. The canonical link for it is here.

Posted to devnull@infra.apache.org by "sarveshkesharwani (GitHub)" <gi...@apache.org> on 2018/08/23 05:30:56 UTC

[GitHub] [incubator-netbeans] sarveshkesharwani opened pull request #766: [NETBEANS-1074] performance.web module review 2nd donation

Changed licenses of some files

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/766 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] geertjanw closed pull request #766: [NETBEANS-1074] Module Review performance.web

Posted by "geertjanw (GitHub)" <gi...@apache.org>.

[ pull request closed by geertjanw ]

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/766 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] junichi11 commented on issue #766: [NETBEANS-1074] performance.web Module Review

Posted by "junichi11 (GitHub)" <gi...@apache.org>.

You should use the same title(of PR and commit message) pattern as other PRs. e.g. see #757

Other than that is OK :) Thanks!

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/766 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] geertjanw commented on issue #766: [NETBEANS-1074] Module Review performance.web

Posted by "geertjanw (GitHub)" <gi...@apache.org>.

Thanks, merging.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/766 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-netbeans] sarveshkesharwani commented on issue #766: [NETBEANS-1074] Module Review performance.web

Posted by "sarveshkesharwani (GitHub)" <gi...@apache.org>.

@junichi11 , Thanks for the review. I have changed the commit message and the title.

[ Full content available at: https://github.com/apache/incubator-netbeans/pull/766 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org