You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/03/18 04:19:25 UTC
[jira] Created: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Fix findBugs warnings in UpgradeUtilities.
------------------------------------------
Key: HADOOP-3036
URL: https://issues.apache.org/jira/browse/HADOOP-3036
Project: Hadoop Core
Issue Type: Bug
Components: dfs, test
Affects Versions: 0.15.0
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 0.17.0
There are 2 findBugs warning in UpgradeUtilities.
- toString() applied to a String
- not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-3036:
----------------------------------------
Status: Patch Available (was: Open)
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580210#action_12580210 ]
Hadoop QA commented on HADOOP-3036:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12378147/UpgradeUtilityBugs1.patch
against trunk revision 619744.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1989/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1989/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1989/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/1989/console
This message is automatically generated.
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch, UpgradeUtilityBugs1.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580749#action_12580749 ]
Hudson commented on HADOOP-3036:
--------------------------------
Integrated in Hadoop-trunk #434 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/434/])
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch, UpgradeUtilityBugs1.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-3036:
----------------------------------------
Attachment: UpgradeUtilityBugs.patch
This fixes the warnings.
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-3036:
----------------------------------------
Attachment: UpgradeUtilityBugs1.patch
Corrected indentation.
Corrected coding style.
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch, UpgradeUtilityBugs1.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3036:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Konstantin!
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch, UpgradeUtilityBugs1.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3036) Fix findBugs warnings in
UpgradeUtilities.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579946#action_12579946 ]
Nigel Daley commented on HADOOP-3036:
-------------------------------------
Code review, 2 nits:
* looks like 1st "continue" isn't indented properly in the patch
* please add brackets for both if statements that have single-line bodies (per Java code style conventions)
> Fix findBugs warnings in UpgradeUtilities.
> ------------------------------------------
>
> Key: HADOOP-3036
> URL: https://issues.apache.org/jira/browse/HADOOP-3036
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Affects Versions: 0.15.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.17.0
>
> Attachments: UpgradeUtilityBugs.patch
>
>
> There are 2 findBugs warning in UpgradeUtilities.
> - toString() applied to a String
> - not closing InputStream.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.