[GitHub] [flink] curcur commented on a change in pull request #18964: [FLINK-26455][state/changelog] Don't fail on materialization cancellation

[GitBox <gi...@apache.org>]

curcur commented on a change in pull request #18964:
URL: https://github.com/apache/flink/pull/18964#discussion_r819401856



##########
File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java
##########
@@ -166,6 +167,10 @@ private void asyncMaterializationPhase(
                                         subtaskName,
                                         upTo);
 
+                                scheduleNextMaterialization();
+                            } else if (throwable instanceof CancellationException) {
+                                // likely due to task cancellation or abortion notification
+                                LOG.info("materialization cancelled", throwable);
                                 scheduleNextMaterialization();
                             } else {

Review comment:
       - If a task gets a `CancellationException`, shouldn't it fail the whole job?
   - Why checkpoint abortion notification can pass `CancellationException` to the part of materialization? Materialization should be independent from Checkpointing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org