You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "polawat phetra (JIRA)" <de...@tapestry.apache.org> on 2007/06/27 03:37:25 UTC
[jira] Created: (TAPESTRY-1605) request.setEncoding in
RequestEncodingInitializerImpl has no effect on 'form submit event'.
request.setEncoding in RequestEncodingInitializerImpl has no effect on 'form submit event'.
-------------------------------------------------------------------------------------------
Key: TAPESTRY-1605
URL: https://issues.apache.org/jira/browse/TAPESTRY-1605
Project: Tapestry
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.0.5
Reporter: polawat phetra
Due to changeset 550147 that fix issue "tapestry-1294",
request.setCharacterEncoding is not working in case of form submit data event
because of method request.setEncoding in RequestEncodingInitializerImpl is called after
request.getParameter(InternalConstants.PAGE_CONTEXT_NAME) in ComponentActionDispatcher.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1605) The request encoding (for
component action requests) occurs too late; after query parameters of the
request have been accessed, which prevents the proper request encoding from
being used
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574298#action_12574298 ]
Howard M. Lewis Ship commented on TAPESTRY-1605:
------------------------------------------------
In the use case where an action is for a page off of the active page, the page name in the URL will now be the active page (so that the request encoding can be determined) and a query parameter will be used to store the containing page.
> The request encoding (for component action requests) occurs too late; after query parameters of the request have been accessed, which prevents the proper request encoding from being used
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1605
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1605
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: polawat phetra
> Assignee: Howard M. Lewis Ship
>
> Due to changeset 550147 that fix issue "tapestry-1294",
> request.setCharacterEncoding is not working in case of form submit data event
> because of method request.setEncoding in RequestEncodingInitializerImpl is called after
> request.getParameter(InternalConstants.PAGE_CONTEXT_NAME) in ComponentActionDispatcher.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-1605) request.setEncoding in
RequestEncodingInitializerImpl has no effect on 'form submit event'.
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAPESTRY-1605:
----------------------------------------------
Assignee: Howard M. Lewis Ship
> request.setEncoding in RequestEncodingInitializerImpl has no effect on 'form submit event'.
> -------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1605
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1605
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: polawat phetra
> Assignee: Howard M. Lewis Ship
>
> Due to changeset 550147 that fix issue "tapestry-1294",
> request.setCharacterEncoding is not working in case of form submit data event
> because of method request.setEncoding in RequestEncodingInitializerImpl is called after
> request.getParameter(InternalConstants.PAGE_CONTEXT_NAME) in ComponentActionDispatcher.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-1605) The request encoding (for component
action requests) occurs too late; after query parameters of the request
have been accessed, which prevents the proper request encoding from being
used
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAPESTRY-1605:
-------------------------------------------
Summary: The request encoding (for component action requests) occurs too late; after query parameters of the request have been accessed, which prevents the proper request encoding from being used (was: request.setEncoding in RequestEncodingInitializerImpl has no effect on 'form submit event'.)
> The request encoding (for component action requests) occurs too late; after query parameters of the request have been accessed, which prevents the proper request encoding from being used
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1605
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1605
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: polawat phetra
> Assignee: Howard M. Lewis Ship
>
> Due to changeset 550147 that fix issue "tapestry-1294",
> request.setCharacterEncoding is not working in case of form submit data event
> because of method request.setEncoding in RequestEncodingInitializerImpl is called after
> request.getParameter(InternalConstants.PAGE_CONTEXT_NAME) in ComponentActionDispatcher.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-1605) The request encoding (for component
action requests) occurs too late; after query parameters of the request
have been accessed, which prevents the proper request encoding from being
used
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-1605.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.11
> The request encoding (for component action requests) occurs too late; after query parameters of the request have been accessed, which prevents the proper request encoding from being used
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1605
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1605
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: polawat phetra
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.11
>
>
> Due to changeset 550147 that fix issue "tapestry-1294",
> request.setCharacterEncoding is not working in case of form submit data event
> because of method request.setEncoding in RequestEncodingInitializerImpl is called after
> request.getParameter(InternalConstants.PAGE_CONTEXT_NAME) in ComponentActionDispatcher.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-1605) The request encoding (for
component action requests) occurs too late; after query parameters of the
request have been accessed, which prevents the proper request encoding from
being used
Posted by "polawat phetra (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574419#action_12574419 ]
polawat phetra commented on TAPESTRY-1605:
------------------------------------------
I have test your solution and find a new issue.
This is a stack trace that show the problem.
The HttpServletRequest object is access by ClientPersistentFieldStrategy with activate by PageImpl.attached()
(revision 632972)
======================================================
RequestImpl.getParameter(String) line: 56 <<+++++++ ACCESS REQUEST PARAMETER ++++++++>>
...
ClientPersistentFieldStorageImpl.<init>(Request) line: 120
...
NativeConstructorAccessorImpl.newInstance(Object[]) line: 39
DelegatingConstructorAccessorImpl.newInstance(Object[]) line: 27
Constructor<T>.newInstance(Object...) line: 494
ConstructorServiceCreator.createObject() line: 51
PerThreadServiceCreator.createObject() line: 53
...
ClientPersistentFieldStrategy.gatherFieldChanges(String) line: 39
...
PersistentFieldManagerImpl.gatherChanges(String) line: 65
...
PageImpl.getFieldChange(String, String) line: 171
InternalComponentResourcesImpl.getFieldChange(String) line: 105
InternalComponentResourcesImpl.hasFieldChange(String) line: 115
Form.containingPageDidAttach() line: not available
ComponentPageElementImpl$2.run(Component) line: 71
ComponentPageElementImpl.invoke(boolean, ComponentCallback) line: 880
ComponentPageElementImpl.containingPageDidAttach() line: 706
PageImpl.attached() line: 146
RequestPageCacheImpl.get(String) line: 45
...
RequestEncodingInitializerImpl.initializeRequestEncoding(String) line: 41 <<-++++++ HERE 's a PROBLEM
...
ComponentEventDispatcher.dispatch(Request, Response) line: 119
...
TapestryModule$13.service(Request, Response) line: 928
AppModule$1.service(Request, Response, RequestHandler) line: 57
...
LocalizationFilter.service(Request, Response, RequestHandler) line: 42
...
TapestryModule$3.service(Request, Response, RequestHandler) line: 539
======================================================
I think that the best solution is just use ServletFilter or RequestFilter to set the character encoding.
> The request encoding (for component action requests) occurs too late; after query parameters of the request have been accessed, which prevents the proper request encoding from being used
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: TAPESTRY-1605
> URL: https://issues.apache.org/jira/browse/TAPESTRY-1605
> Project: Tapestry
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.0.5
> Reporter: polawat phetra
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.11
>
>
> Due to changeset 550147 that fix issue "tapestry-1294",
> request.setCharacterEncoding is not working in case of form submit data event
> because of method request.setEncoding in RequestEncodingInitializerImpl is called after
> request.getParameter(InternalConstants.PAGE_CONTEXT_NAME) in ComponentActionDispatcher.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org