You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "yanye666 (via GitHub)" <gi...@apache.org> on 2023/02/12 06:01:53 UTC
[GitHub] [skywalking-java] yanye666 opened a new pull request, #455: Clickhouse jdbc
yanye666 opened a new pull request, #455:
URL: https://github.com/apache/skywalking-java/pull/455
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Add an agent plugin to support <clickhouse-jdbc-0.3.2.*>
- [ x] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ x] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [x ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [x ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #455: Add plugin to support clickhouse jdbc
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#discussion_r1103804253
##########
apm-sniffer/apm-sdk-plugin/clickhouse-0.3.2.x-plugin/src/main/resources/skywalking-plugin.def:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+clickhouse-0.3.2.x=org.apache.skywalking.apm.plugin.jdbc.clickhouse.v32.define.ConnectionInstrumentation
Review Comment:
The plugin of 0.3.x uses `clickhouse-0.3.x`. As 0.3.2 is an incompatible change, that keys should be updated to `clickhouse-0.3.1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #455: Add plugin to support clickhouse jdbc
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1427029851
I am confused, clickhouse-jdbc plugin exists for 0.3.0 and 0.3.1. What does actually change in 0.3.2? Why do we have to write all rather than doing some compatible work on the original one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #455: Add plugin to support clickhouse jdbc
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1426972811
Your local env should be JDK17, the class file could be jdk8 like most plugins.
Also, we should plugin test doc to write tests to verify plugin with a demo application.
https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/java-plugin-development-guide/#contribute-plugins-to-the-apache-skywalking-repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] yanye666 commented on pull request #455: Clickhouse jdbc
Posted by "yanye666 (via GitHub)" <gi...@apache.org>.
yanye666 commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1426951516
Hello, I'm having a problem compiling the project.
类文件具有错误的版本 55.0, 应为 52.0
How is this compatible? This should be supported by jdk1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] yanye666 commented on pull request #455: Add plugin to support clickhouse jdbc
Posted by "yanye666 (via GitHub)" <gi...@apache.org>.
yanye666 commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1427031491
> I am confused, clickhouse-jdbc plugin exists for 0.3.0 and 0.3.1. What does actually change in 0.3.2? Why do we have to write all rather than doing some compatible work on the original one?
The author refactored the new version, and the version-related packages will be removed later
https://github.com/ClickHouse/clickhouse-java/issues/768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #455: Add plugin to support clickhouse jdbc
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1427032765
> > I am confused, clickhouse-jdbc plugin exists for 0.3.0 and 0.3.1. What does actually change in 0.3.2? Why do we have to write all rather than doing some compatible work on the original one?
>
> The author refactored the new version, and the version-related packages will be removed later
>
> [ClickHouse/clickhouse-java#768](https://github.com/ClickHouse/clickhouse-java/issues/768)
If so, please update the previous `clickhouse-0.3.x-plugin` to `clickhouse-0.3.1-plugin`(same for scenario name). And you should add your test into GitHub Action like the `clickhouse-0.3.x-scenario`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #455: Add plugin to support clickhouse jdbc
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1427035012
> Run tools/plugin/check-javaagent-plugin-list.sh
--- /home/runner/work/skywalking-java/skywalking-java/tools/plugin/md-javaagent-plugin-list.txt 2023-02-12 13:2[6](https://github.com/apache/skywalking-java/actions/runs/4156385490/jobs/7190419515#step:5:7):52.0502[7](https://github.com/apache/skywalking-java/actions/runs/4156385490/jobs/7190419515#step:5:8)7302 +0000
+++ /home/runner/work/skywalking-java/skywalking-java/tools/plugin/genernate-javaagent-plugin-list.txt 2023-02-12 13:26:52.042277371 +0000
`Plugin-list.md` should be updated according to your new plugin key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] yanye666 commented on a diff in pull request #455: Add plugin to support clickhouse jdbc
Posted by "yanye666 (via GitHub)" <gi...@apache.org>.
yanye666 commented on code in PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#discussion_r1103805448
##########
apm-sniffer/apm-sdk-plugin/clickhouse-0.3.2.x-plugin/src/main/resources/skywalking-plugin.def:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+clickhouse-0.3.2.x=org.apache.skywalking.apm.plugin.jdbc.clickhouse.v32.define.ConnectionInstrumentation
Review Comment:
clickhouse-0.3.x-plugin to clickhouse-0.3.1-plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #455: Add plugin to support clickhouse jdbc
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #455:
URL: https://github.com/apache/skywalking-java/pull/455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] yanye666 commented on pull request #455: Add plugin to support clickhouse jdbc
Posted by "yanye666 (via GitHub)" <gi...@apache.org>.
yanye666 commented on PR #455:
URL: https://github.com/apache/skywalking-java/pull/455#issuecomment-1427024638
> Your local env should be JDK17, the class file could be jdk8 like most plugins. Also, we should plugin test doc to write tests to verify plugin with a demo application.
>
> https://skywalking.apache.org/docs/skywalking-java/next/en/setup/service-agent/java-agent/java-plugin-development-guide/#contribute-plugins-to-the-apache-skywalking-repository
please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org