You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/10/21 16:44:29 UTC
Review Request 26972: Add Service should not be setting HDFS configs
when HDFS is not present
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26972/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
Bugs: AMBARI-7883
https://issues.apache.org/jira/browse/AMBARI-7883
Repository: ambari
Description
-------
1) Install a cluster w/o HDFS (for example, just kafka, or just storm, or just knox)
2) go an add service (add something that doesn't need HDFS)
3) when add service is complete, HDFS configs have been rev'd and show up under Config History
Issue is: there is no HDFS. Add Service should not be setting any HDFS configs when HDFS is not installed.
Diffs
-----
ambari-web/app/controllers/wizard/step8_controller.js 470c876
ambari-web/test/controllers/wizard/step8_test.js 087badc
Diff: https://reviews.apache.org/r/26972/diff/
Testing
-------
4696 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach
Re: Review Request 26972: Add Service should not be setting HDFS
configs when HDFS is not present
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26972/#review57580
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 21, 2014, 2:44 п.п., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26972/
> -----------------------------------------------------------
>
> (Updated Окт. 21, 2014, 2:44 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7883
> https://issues.apache.org/jira/browse/AMBARI-7883
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Install a cluster w/o HDFS (for example, just kafka, or just storm, or just knox)
> 2) go an add service (add something that doesn't need HDFS)
> 3) when add service is complete, HDFS configs have been rev'd and show up under Config History
> Issue is: there is no HDFS. Add Service should not be setting any HDFS configs when HDFS is not installed.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step8_controller.js 470c876
> ambari-web/test/controllers/wizard/step8_test.js 087badc
>
> Diff: https://reviews.apache.org/r/26972/diff/
>
>
> Testing
> -------
>
> 4696 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 26972: Add Service should not be setting HDFS
configs when HDFS is not present
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26972/#review57579
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Oct. 21, 2014, 2:44 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26972/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2014, 2:44 p.m.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7883
> https://issues.apache.org/jira/browse/AMBARI-7883
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1) Install a cluster w/o HDFS (for example, just kafka, or just storm, or just knox)
> 2) go an add service (add something that doesn't need HDFS)
> 3) when add service is complete, HDFS configs have been rev'd and show up under Config History
> Issue is: there is no HDFS. Add Service should not be setting any HDFS configs when HDFS is not installed.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/wizard/step8_controller.js 470c876
> ambari-web/test/controllers/wizard/step8_test.js 087badc
>
> Diff: https://reviews.apache.org/r/26972/diff/
>
>
> Testing
> -------
>
> 4696 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>