You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/28 01:05:20 UTC
[GitHub] [maven-surefire] olamy opened a new pull request #480: Improve jacoco setup
olamy opened a new pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480
Signed-off-by: Olivier Lamy <ol...@apache.org>
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817379420
##########
File path: Jenkinsfile
##########
@@ -30,7 +30,7 @@ properties(
]
)
final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.2.x', '3.8.x'] : ['3.8.x']
Review comment:
the first version of maven will be used to deploy artifacts - maybe better is use the latest version to deploy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r819424925
##########
File path: Jenkinsfile
##########
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String mvnName, goals, options
try {
if (makeReports) {
jacoco(changeBuildStatus: false,
- execPattern: '**/*.exec',
+ execPattern: '**/target/jacoco*.exec',
Review comment:
@olamy
Performance? Open the online logs as me and you will see that the performance is the last problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817134239
##########
File path: Jenkinsfile
##########
@@ -30,7 +30,7 @@ properties(
]
)
final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x']
Review comment:
current used Maven api is 3.2.5 ... so we need check with it.
3.8.x is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy merged pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
olamy commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817139797
##########
File path: Jenkinsfile
##########
@@ -30,7 +30,7 @@ properties(
]
)
final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x']
Review comment:
@slawekjaranowski sounds a good explanation to change that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
olamy commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817391997
##########
File path: Jenkinsfile
##########
@@ -30,7 +30,7 @@ properties(
]
)
final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.2.x', '3.8.x'] : ['3.8.x']
Review comment:
good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817111492
##########
File path: Jenkinsfile
##########
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String mvnName, goals, options
try {
if (makeReports) {
jacoco(changeBuildStatus: false,
- execPattern: '**/*.exec',
+ execPattern: '**/target/jacoco*.exec',
Review comment:
Why you change this line?
It does not make any difference!
Do we have any other tools which produce `exec` files? No, we don't!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
olamy commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817141822
##########
File path: Jenkinsfile
##########
@@ -30,7 +30,7 @@ properties(
]
)
final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x']
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817109165
##########
File path: Jenkinsfile
##########
@@ -30,7 +30,7 @@ properties(
]
)
final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he']
-final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x']
+final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x']
Review comment:
This change is not acceptable. We want to and we will accept the range Maven 3.2+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Posted by GitBox <gi...@apache.org>.
olamy commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817140781
##########
File path: Jenkinsfile
##########
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String mvnName, goals, options
try {
if (makeReports) {
jacoco(changeBuildStatus: false,
- execPattern: '**/*.exec',
+ execPattern: '**/target/jacoco*.exec',
Review comment:
it's to avoid a deep scanning which have a very poor performance where we know exactly file names we are looking for `jacoco*.exec` and directories. scanning everything is a waste of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org