You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/28 20:39:53 UTC

[GitHub] [incubator-superset] kristw edited a comment on issue #6610: Add support to Apache Drill

kristw edited a comment on issue #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-477751276
 
 
   @cgivre I am not familiar with the backend code so I cannot fully review the code.
   
   However, regarding your request to merge as **Work in Progress**, Superset is used in production environment for many organizations, making `master` stability very important. Therefore, I will have a hard time merging incompleted code into master.  PR are usually labelled **WIP (Work in Progress)** when the work is not completed so reviewers will not even review the PR.
   
   However, if you feel that there are parts of this PR that are solid already and ready to be merged, please keep only that part and get rid of everything else. You can also help the reviewers understand what are the remaining issues that make you say this is still WIP. 
   
   If you can clean out the incompleted parts, after receiving approval from @mistercrunch or other backend experts, we can merge.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org