You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/05/15 17:45:12 UTC
Review Request 34272: Kerberos: Principals fail to be created if
whitespace exists in generated passwords
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34272/
-----------------------------------------------------------
Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Nettleton.
Bugs: AMBARI-11169
https://issues.apache.org/jira/browse/AMBARI-11169
Repository: ambari
Description
-------
Principals fail to be created if whitespace exists in generated passwords.
#failure condition
```
add_principal -pw 265 V$^+91axff4i56 ambari-qa@EXAMPLE.COM
```
To fix this, quotes are needed around the password:
#fix}
```
add_principal -pw "265 V$^+91axff4i56" ambari-qa@EXAMPLE.COM
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 5614692
Diff: https://reviews.apache.org/r/34272/diff/
Testing
-------
Manually tested to ensure whitespace charaters in the password do not cause issues creating principals in an MIT KDC.
Thanks,
Robert Levas
Re: Review Request 34272: Kerberos: Principals fail to be created if
whitespace exists in generated passwords
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34272/#review83933
-----------------------------------------------------------
Ship it!
Ship It!
- John Speidel
On May 15, 2015, 3:45 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34272/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 3:45 p.m.)
>
>
> Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Nettleton.
>
>
> Bugs: AMBARI-11169
> https://issues.apache.org/jira/browse/AMBARI-11169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Principals fail to be created if whitespace exists in generated passwords.
>
> #failure condition
> ```
> add_principal -pw 265 V$^+91axff4i56 ambari-qa@EXAMPLE.COM
> ```
> To fix this, quotes are needed around the password:
>
> #fix
> ```
> add_principal -pw "265 V$^+91axff4i56" ambari-qa@EXAMPLE.COM
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 5614692
>
> Diff: https://reviews.apache.org/r/34272/diff/
>
>
> Testing
> -------
>
> Manually tested to ensure whitespace charaters in the password do not cause issues creating principals in an MIT KDC.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 34272: Kerberos: Principals fail to be created if
whitespace exists in generated passwords
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34272/#review83934
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On May 15, 2015, 3:45 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34272/
> -----------------------------------------------------------
>
> (Updated May 15, 2015, 3:45 p.m.)
>
>
> Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Nettleton.
>
>
> Bugs: AMBARI-11169
> https://issues.apache.org/jira/browse/AMBARI-11169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Principals fail to be created if whitespace exists in generated passwords.
>
> #failure condition
> ```
> add_principal -pw 265 V$^+91axff4i56 ambari-qa@EXAMPLE.COM
> ```
> To fix this, quotes are needed around the password:
>
> #fix
> ```
> add_principal -pw "265 V$^+91axff4i56" ambari-qa@EXAMPLE.COM
> ```
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 5614692
>
> Diff: https://reviews.apache.org/r/34272/diff/
>
>
> Testing
> -------
>
> Manually tested to ensure whitespace charaters in the password do not cause issues creating principals in an MIT KDC.
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 34272: Kerberos: Principals fail to be created if
whitespace exists in generated passwords
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34272/
-----------------------------------------------------------
(Updated May 17, 2015, 6:09 p.m.)
Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Nettleton.
Changes
-------
Removed code to escape double quotes needed to surround passwords in kadmin queries to allow for whitespace characters.
Bugs: AMBARI-11169
https://issues.apache.org/jira/browse/AMBARI-11169
Repository: ambari
Description
-------
Principals fail to be created if whitespace exists in generated passwords.
#failure condition
```
add_principal -pw 265 V$^+91axff4i56 ambari-qa@EXAMPLE.COM
```
To fix this, quotes are needed around the password:
#fix
```
add_principal -pw "265 V$^+91axff4i56" ambari-qa@EXAMPLE.COM
```
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 5614692
Diff: https://reviews.apache.org/r/34272/diff/
Testing
-------
Manually tested to ensure whitespace charaters in the password do not cause issues creating principals in an MIT KDC.
Thanks,
Robert Levas
Re: Review Request 34272: Kerberos: Principals fail to be created if
whitespace exists in generated passwords
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34272/
-----------------------------------------------------------
(Updated May 15, 2015, 11:45 a.m.)
Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Nettleton.
Bugs: AMBARI-11169
https://issues.apache.org/jira/browse/AMBARI-11169
Repository: ambari
Description (updated)
-------
Principals fail to be created if whitespace exists in generated passwords.
#failure condition
```
add_principal -pw 265 V$^+91axff4i56 ambari-qa@EXAMPLE.COM
```
To fix this, quotes are needed around the password:
#fix
```
add_principal -pw "265 V$^+91axff4i56" ambari-qa@EXAMPLE.COM
```
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java 5614692
Diff: https://reviews.apache.org/r/34272/diff/
Testing
-------
Manually tested to ensure whitespace charaters in the password do not cause issues creating principals in an MIT KDC.
Thanks,
Robert Levas