[GitHub] [superset] zephyring commented on a diff in pull request #25118: feat: add denylist to stats logger

["zephyring (via GitHub)" <gi...@apache.org>]

zephyring commented on code in PR #25118:
URL: https://github.com/apache/superset/pull/25118#discussion_r1309418940


##########
docs/docs/installation/event-logging.mdx:
##########
@@ -56,5 +56,13 @@ from superset.stats_logger import StatsdStatsLogger
 STATS_LOGGER = StatsdStatsLogger(host='localhost', port=8125, prefix='superset')
 ```
 
+You can also pass metric names that should be ignored via an optional `metric_denylist` parameter:
+
+```
+STATS_LOGGER = StatsdStatsLogger(host='localhost', port=8125, prefix='superset', metric_denylist={"reports.scheduler"})

Review Comment:
   I wonder if it's better to promote `metrics_denylist` to be a config that can be overridden. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org