You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/06 01:21:05 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #1872: Core: add contains_nan to field_summary

rdblue commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r536928127



##########
File path: core/src/main/java/org/apache/iceberg/GenericPartitionFieldSummary.java
##########
@@ -72,10 +73,11 @@ public GenericPartitionFieldSummary(Schema avroSchema) {
     }
   }
 
-  public GenericPartitionFieldSummary(boolean containsNull, ByteBuffer lowerBound,
+  public GenericPartitionFieldSummary(boolean containsNull, Boolean containsNaN, ByteBuffer lowerBound,

Review comment:
       Why use `Boolean` instead of the primitive here? Is there a place that constructs these without knowing whether there are `NaN` values?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org