[GitHub] [apisix-ingress-controller] Gallardot commented on a diff in pull request #1717: feat: ApisixConsumer support ingressClass

["Gallardot (via GitHub)" <gi...@apache.org>]

Gallardot commented on code in PR #1717:
URL: https://github.com/apache/apisix-ingress-controller/pull/1717#discussion_r1131890520


##########
pkg/providers/apisix/apisix_consumer.go:
##########
@@ -269,6 +272,9 @@ func (c *apisixConsumerController) onUpdate(oldObj, newObj interface{}) {
 	if !c.namespaceProvider.IsWatchingNamespace(key) {
 		return
 	}
+	if !c.isEffective(curr) {

Review Comment:
   When I communicated with @tao12345666333  on wechat, in the `onUpdate` function, the value of `IngressClassName` might be changed from apisix to xxx, which should generate a delete event.
   There are similar issues with other crd implementations such as apisixupstream. Maybe we can create a new PR focus to solve this problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org