[GitHub] [flink] KurtYoung commented on a change in pull request #10454: [FLINK-13195][sql-client] Add create(drop) table support for SqlClient

[GitBox <gi...@apache.org>]

KurtYoung commented on a change in pull request #10454: [FLINK-13195][sql-client] Add create(drop) table support for SqlClient
URL: https://github.com/apache/flink/pull/10454#discussion_r354684576
 
 

 ##########
 File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
 ##########
 @@ -584,4 +655,69 @@ private Pipeline createPipeline(String name) {
 			return execEnv.createProgramPlan(name);
 		}
 	}
+
+	//~ Inner Class -------------------------------------------------------------------------------
+
+	/** Builder for {@link ExecutionContext}. */
+	public static class Builder {
+		// Required members.
+		private final SessionContext sessionContext;
+		private final List<URL> dependencies;
+		private final Configuration configuration;
+		private final ClusterClientServiceLoader serviceLoader;
+		private final Options commandLineOptions;
+		private final List<CustomCommandLine> commandLines;
+
+		private Environment defaultEnv;
+		private Environment env;
 
 Review comment:
   use another meaningful name rather than `env`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services