You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "James Hayes (JIRA)" <ji...@apache.org> on 2008/12/18 14:08:44 UTC
[jira] Created: (IO-188) DefaultFTPFileEntryParserFactory Does not
work with Netware FTP server returning "NETWARE TYPE: L8"
DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
---------------------------------------------------------------------------------------------------
Key: IO-188
URL: https://issues.apache.org/jira/browse/IO-188
Project: Commons IO
Issue Type: Bug
Reporter: James Hayes
Fix For: 2.0
We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
|| (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
{
parser = createUnixFTPEntryParser();
}
I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NET-250) DefaultFTPFileEntryParserFactory Does
not work with Netware FTP server returning "NETWARE TYPE: L8"
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666004#action_12666004 ]
Jukka Zitting commented on NET-250:
-----------------------------------
This was filed as IO-188, but I moved this to NET-250 since this is apparently a commons-net issue.
> DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
> ---------------------------------------------------------------------------------------------------
>
> Key: NET-250
> URL: https://issues.apache.org/jira/browse/NET-250
> Project: Commons Net
> Issue Type: Bug
> Reporter: James Hayes
>
> We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
> The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
> if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
> || (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
> {
> parser = createUnixFTPEntryParser();
> }
> I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
> In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Moved: (NET-250) DefaultFTPFileEntryParserFactory Does not
work with Netware FTP server returning "NETWARE TYPE: L8"
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting moved IO-188 to NET-250:
--------------------------------------
Fix Version/s: (was: 2.0)
Key: NET-250 (was: IO-188)
Project: Commons Net (was: Commons IO)
> DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
> ---------------------------------------------------------------------------------------------------
>
> Key: NET-250
> URL: https://issues.apache.org/jira/browse/NET-250
> Project: Commons Net
> Issue Type: Bug
> Reporter: James Hayes
>
> We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
> The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
> if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
> || (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
> {
> parser = createUnixFTPEntryParser();
> }
> I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
> In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NET-250) DefaultFTPFileEntryParserFactory Does
not work with Netware FTP server returning "NETWARE TYPE: L8"
Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666478#action_12666478 ]
Rory Winston commented on NET-250:
----------------------------------
Hi
You are correct - this should be alleviated by changing the order of the comparisons. I will move the L8 check to the end, which should allow more specific cases to be picked up first.
> DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
> ---------------------------------------------------------------------------------------------------
>
> Key: NET-250
> URL: https://issues.apache.org/jira/browse/NET-250
> Project: Commons Net
> Issue Type: Bug
> Reporter: James Hayes
>
> We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
> The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
> {code}
> if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
> || (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
> {
> parser = createUnixFTPEntryParser();
> }
> {code}
> I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
> In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NET-250) DefaultFTPFileEntryParserFactory Does not
work with Netware FTP server returning "NETWARE TYPE: L8"
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated NET-250:
------------------------------
Description:
We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
{code}
if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
|| (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
{
parser = createUnixFTPEntryParser();
}
{code}
I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
was:
We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
|| (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
{
parser = createUnixFTPEntryParser();
}
I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
> DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
> ---------------------------------------------------------------------------------------------------
>
> Key: NET-250
> URL: https://issues.apache.org/jira/browse/NET-250
> Project: Commons Net
> Issue Type: Bug
> Reporter: James Hayes
>
> We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
> The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
> {code}
> if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
> || (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
> {
> parser = createUnixFTPEntryParser();
> }
> {code}
> I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
> In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (NET-250) DefaultFTPFileEntryParserFactory Does not
work with Netware FTP server returning "NETWARE TYPE: L8"
Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rory Winston closed NET-250.
----------------------------
Resolution: Fixed
Fixed.
> DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
> ---------------------------------------------------------------------------------------------------
>
> Key: NET-250
> URL: https://issues.apache.org/jira/browse/NET-250
> Project: Commons Net
> Issue Type: Bug
> Reporter: James Hayes
>
> We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
> The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
> {code}
> if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
> || (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
> {
> parser = createUnixFTPEntryParser();
> }
> {code}
> I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
> In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NET-250) DefaultFTPFileEntryParserFactory Does not
work with Netware FTP server returning "NETWARE TYPE: L8"
Posted by "Rory Winston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rory Winston updated NET-250:
-----------------------------
Fix Version/s: 2.1
> DefaultFTPFileEntryParserFactory Does not work with Netware FTP server returning "NETWARE TYPE: L8"
> ---------------------------------------------------------------------------------------------------
>
> Key: NET-250
> URL: https://issues.apache.org/jira/browse/NET-250
> Project: Commons Net
> Issue Type: Bug
> Reporter: James Hayes
> Fix For: 2.1
>
>
> We have just being trying to upgrade from the old NetComponents-1.3.8 to the new apache commons-net-2.0 The only thing we really needed to do is to change some imports and our project compiled.
> The problem is that listFiles does not work any more with our netware ftp server! I have done some debugging and found that the problem is when creating a FTPFileEntryParser from the class DefaultFTPFileEntryParserFactory it returns a Unix entry parser due the code:
> {code}
> if ((ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
> || (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0))
> {
> parser = createUnixFTPEntryParser();
> }
> {code}
> I understand that the SYST_L8 is used to identify that the system is unknown and so per default takes the UNIX server, however our FTP server returns "NETWARE TYPE: L8" and should really be identified as a netware server. maybe this L8 test could be done at the end of these massive if, else statements?
> In the meanwhile i have created by own FTPFileEntryParserFactory which does this and it works. The question is, is it a bug and should this change also be done in the commons?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.