[jira] [Comment Edited] (BOOKKEEPER-623) Metadata is having extra Segment which is causing AutoRecovery to fail

["Sijie Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681461#comment-13681461 ] 

Sijie Guo edited comment on BOOKKEEPER-623 at 6/12/13 6:19 PM:
---------------------------------------------------------------

vinay, thanks for explanation. but you still can't avoid adding extra segment if handling failure response came before auth failure. and also, another case, an ensemble change happened first and bring an unauthed bookie in, the extra segment would still be added to the ledger metadata.

so a bunch of cases would introduce extra segment in closed state, which could not be avoided. so I don't see the value to avoid adding extra segments in a closed ledger, since lastEntryId already defined the boundary. we definitely should fix auto-recovery issue rather than this.
                
      was (Author: hustlmsp):
    vinay, thanks for explanation. but you still can't avoid adding extra segment if handling failure response came before auth failure. and also, another case, an ensemble change happened first and bring an unauthed bookie in, the extra segment would still be added to the ledger metadata.

so a bunch of cases would introduce extra segment in closed state, which could not be avoided. so I don't know it is valuable to make the change as you proposed. we definitely should fix auto-recovery issue rather than this.
                  
> Metadata is having extra Segment which is causing AutoRecovery to fail
> ----------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-623
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-623
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-server
>    Affects Versions: 4.2.1, 4.3.0
>            Reporter: Vinay
>            Assignee: Vinay
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-623.patch, BOOKKEEPER-623.patch
>
>
> With the almost same testcase mentioned in the BOOKKEEPER-584, Ledger metadata is getting added with extra segment during failure handling of bookies along with fencing. 
> Only difference in the testcase is .
> 1. Before bookie failures some entries were already written
> 2. And after bookies failed ( First bookie will throw LedgerFenced/Unauthorized exception, and second bookie is slow/dead bookie ), Number of entries written asynchrounously is n*ensembleSize+1
> Note that, Unauthorized/FencedException callback comes first, then other bookie failure callback comes.
> I will attach a TestCase along with patch for this shortly. Testcase is modified version of attached testcase in BOOKKEEPER-584

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira