You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vincipop <gi...@git.apache.org> on 2015/09/23 15:10:52 UTC
[GitHub] cordova-plugin-contacts pull request: Get input stream from relati...
GitHub user vincipop opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77
Get input stream from relative path
"Get an input stream based on file path or uri " didn't work for relative paths so modified line 1635
The problem is still present for path started with "file:" (full path) : ToDo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vincipop/cordova-plugin-contacts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-contacts/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 94d4a6eb7aadd16011c93c8c098cecd02f4ced1b
Author: vincipop <vi...@yahoo.fr>
Date: 2015-09-23T13:02:06Z
Update ContactAccessorSdk.java
"Get an input stream based on file path or uri " didn't work for relative paths so modified line 1635
The problem is still present for path started with "file:" (full path) : ToDo
commit a19faee5772887e47d6f1988d7e3a9e2e5029da3
Author: vincipop <vi...@yahoo.fr>
Date: 2015-09-23T13:04:17Z
Merge pull request #1 from vincipop/vincipop-patch-1
Update ContactAccessorSdk.java for get input stream from relative path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...
Posted by vincipop <gi...@git.apache.org>.
Github user vincipop commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-158021220
Hi @vladimir-kotikov ,
Apache CLA signed
Issue filed on JRA : https://issues.apache.org/jira/browse/CB-10039
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-160630915
@vincipop, looks like your changes does not handle the case, when image path is an absolute path to file outside of assets/storage directory (`/res/images/some_file.jpg` or `file:///res/images/some_file.jpg`).
Could you please try out #94 and let me know if it works for you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...
Posted by vincipop <gi...@git.apache.org>.
Github user vincipop commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-161224895
@vladimir-kotikov, I tried out #94 and it works for me.
Perfect, thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-155436002
Hi @vincipop, before merging could you please sign the Apache CLA? Also it would be great if you filed an issue in [JIRA](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB)
More info on contributing here: http://cordova.apache.org/contribute/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org