You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2023/12/19 11:07:37 UTC
[PR] Add INFO comment when DB not scaned [kvrocks]
jihuayu opened a new pull request, #1956:
URL: https://github.com/apache/kvrocks/pull/1956
I noticed that many people are unaware that they need to run `dbsize scan` first in order to obtain the "keys num" information.
So I have added the logic: when `dbsize scan` has not been executed, the `INFO` command will display a warning to remind the user to run the `dbsize scan` command.
```shell
WARN: DB not scaned, run `dbsize scan` command first.
db0:keys=0,expires=0,avg_ttl=0,expired=0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439245718
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
Review Comment:
it's written in the comment.
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
Review Comment:
it's already written in the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1863560662
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439229780
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ }
Review Comment:
> I wonder why it is in comment rather than an normal key-value line like last_scan_time:0? cc @git-hulk
We suppose this line should be obvious enough for users since it's an annotation for the next field but seems most of them ignored this comment line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439202121
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ }
Review Comment:
I wonder why it is in comment rather than an normal key-value line like `last_scan_time:0`? cc @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439247003
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
Review Comment:
Oh, my mistake. I misunderstood `DBSIZE SCAN` as a noun instead of a command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1862562949
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439247003
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
Review Comment:
Oh, my mistake. I misunderstood `DBSIZE SCAN` as a noun instead of a command.
Thank you for your correction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1868774302
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1873748691
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439239611
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
Review Comment:
Not all users will read the documentation, so I suggest directly writing `dbsize scan` command in the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1873748654
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1862567328
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#issuecomment-1874203034
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=1956&resolved=false&inNewCodePeriod=true)
No data about Coverage
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_kvrocks&pullRequest=1956&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=1956)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439235165
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
Review Comment:
```suggestion
string_stream << "# WARN: DBSIZE SCAN never performed yet\r\n";
} else {
string_stream << "# Last DBSIZE SCAN time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add INFO comment when DB not scaned [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #1956:
URL: https://github.com/apache/kvrocks/pull/1956#discussion_r1439234492
##########
src/server/server.cc:
##########
@@ -1163,7 +1163,11 @@ void Server::GetInfo(const std::string &ns, const std::string §ion, std::str
if (section_cnt++) string_stream << "\r\n";
string_stream << "# Keyspace\r\n";
- string_stream << "# Last scan db time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ if (last_scan_time == 0) {
+ string_stream << "# WARN: DB not scan, run `dbsize scan` command first.\r\n";
+ } else {
+ string_stream << "# Last scan DB time: " << std::put_time(&last_scan_tm, "%a %b %e %H:%M:%S %Y") << "\r\n";
+ }
Review Comment:
Ahh I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org