You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/10/23 19:24:13 UTC
[PR] [NSX] Allow NSX isolated networks [cloudstack]
nvazquez opened a new pull request, #8132:
URL: https://github.com/apache/cloudstack/pull/8132
Allow creating NSX isolated networks (not as VPC tiers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NSX] Allow NSX isolated networks [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8132:
URL: https://github.com/apache/cloudstack/pull/8132#issuecomment-1775935611
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8132?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#8132](https://app.codecov.io/gh/apache/cloudstack/pull/8132?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ced4bb7) into [nsx-integration](https://app.codecov.io/gh/apache/cloudstack/commit/c135fa13ae699dd3cb88ebcf1b42cbc31f522ddf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c135fa1) will **decrease** coverage by `8.75%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## nsx-integration #8132 +/- ##
=====================================================
- Coverage 23.42% 14.68% -8.75%
+ Complexity 23399 12251 -11148
=====================================================
Files 5134 4655 -479
Lines 361983 313843 -48140
Branches 52860 44370 -8490
=====================================================
- Hits 84793 46086 -38707
+ Misses 265359 261710 -3649
+ Partials 11831 6047 -5784
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8132/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8132/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.68% <100.00%> (-2.88%)` | :arrow_down: |
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8132/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8132/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../main/java/com/cloud/offering/NetworkOffering.java](https://app.codecov.io/gh/apache/cloudstack/pull/8132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL29mZmVyaW5nL05ldHdvcmtPZmZlcmluZy5qYXZh) | `100.00% <ø> (ø)` | |
| [...java/com/cloud/server/ConfigurationServerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9Db25maWd1cmF0aW9uU2VydmVySW1wbC5qYXZh) | `58.04% <100.00%> (-1.44%)` | :arrow_down: |
... and [1796 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8132/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NSX] Allow NSX isolated networks [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez merged PR #8132:
URL: https://github.com/apache/cloudstack/pull/8132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org