You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by martincgg <gi...@git.apache.org> on 2014/06/24 12:20:30 UTC

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

GitHub user martincgg opened a pull request:

    https://github.com/apache/cordova-mobile-spec/pull/75

    CB-7009 (WP8) use proper path if windowsphone

    Use a proper filepath to determine if the file exists or not, instead of just throw a ENCODING_ERR error code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/martincgg/cordova-mobile-spec CB-7009

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-mobile-spec/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit b88d103fdc49c00b561f6cb77246be0a91de53c7
Author: Martin Gonzalez <ma...@gmail.com>
Date:   2014-06-24T10:00:18Z

    CB-7009 (WP8) use proper path if windowsphone
    
    Use a proper filename to determine if exists or not, instead of just
    throw a ENCODING_ERR error code.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/75#issuecomment-51419471
  
    no longer valid, closing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

Posted by martincgg <gi...@git.apache.org>.
Github user martincgg closed the pull request at:

    https://github.com/apache/cordova-mobile-spec/pull/75


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-mobile-spec pull request: CB-7009 (WP8) use proper path if...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/75#issuecomment-51418024
  
    is this still valid? with everything moved to plugin tests ...
    merge conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---