You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by "Yusaku Sako (JIRA)" <ji...@apache.org> on 2013/06/14 06:40:20 UTC

[jira] [Commented] (AMBARI-2386) Javascript error encountered occasionally on initializing Hostpopup.

    [ https://issues.apache.org/jira/browse/AMBARI-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683084#comment-13683084 ] 

Yusaku Sako commented on AMBARI-2386:
-------------------------------------

I see that you added checks to avoid referencing invalid objects.
1. It's not necessary to rename "hosts" to "controller.hosts", is it?  Was that done for a specific purpose?
2. Instead of doing someProperty and then findProperty, it would be more efficient to do findProperty once, set it to a variable, and then check to see if the object is valid (someProperty does a scan on the array, and findProperty does another scan).

                
> Javascript error encountered occasionally on initializing Hostpopup.
> --------------------------------------------------------------------
>
>                 Key: AMBARI-2386
>                 URL: https://issues.apache.org/jira/browse/AMBARI-2386
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.2.5
>            Reporter: Jaimin D Jetly
>            Assignee: Jaimin D Jetly
>             Fix For: 1.2.5
>
>         Attachments: AMBARI-2386.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira