You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/04/13 21:04:31 UTC
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18414
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
IMPALA-11244: Run the minicluster for docker-based BE tests
As an optimization, the docker-based tests didn't run
the minicluster for BE tests. Some BE tests now require
the minicluster (DiskIoMgrTest.WriteToRemote*), so this
cannot work with the optimization.
This changes the docker-based tests to start the minicluster
for the BE tests.
Testing:
- Ran a docker-based test job
Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
---
M docker/entrypoint.sh
1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/18414/1
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18414 )
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Apr 2022 01:40:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18414 )
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
IMPALA-11244: Run the minicluster for docker-based BE tests
As an optimization, the docker-based tests didn't run
the minicluster for BE tests. Some BE tests now require
the minicluster (DiskIoMgrTest.WriteToRemote*), so this
cannot work with the optimization.
This changes the docker-based tests to start the minicluster
for the BE tests.
Testing:
- Ran a docker-based test job
Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Reviewed-on: http://gerrit.cloudera.org:8080/18414
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M docker/entrypoint.sh
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18414 )
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
Patch Set 4: Verified+1
Was tested as part of the stack
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 May 2022 00:18:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18414 )
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
Patch Set 4: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 May 2022 21:37:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18414 )
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10444/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 21:25:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11244: Run the minicluster for docker-based BE tests
Posted by "Laszlo Gaal (Cloudera) (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal (Cloudera) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18414 )
Change subject: IMPALA-11244: Run the minicluster for docker-based BE tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18414
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I784a63a02886852e10ccca7c118c22ff7d38b8a3
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal (Cloudera) <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 12:54:03 +0000
Gerrit-HasComments: No