[GitHub] [incubator-superset] graceguo-supercat commented on issue #7895: [dashboard] fix chart showing loading icon when immune fields updated

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #7895: [dashboard] fix chart showing loading icon when immune fields updated
URL: https://github.com/apache/incubator-superset/pull/7895#issuecomment-514000233
 
 
   i am kind of hesitate to rename all `filter_immune_slice_fields` to camelCase `filterImmuneSliceFields`:
   - There are a few read-only config variables that are one-to-one mapped to fields in `JSON Metadata`, like `filter_immune_slice_fields`, `filter_immune_slices`, `timed_refresh_immune_slices`. It will be easier to map feature to its stored configuration, when we globally search the same key in the code base.
   - But this behavior is not consistent, some config variables are converted to camelCase, for example: `expandedSlices`, `refresh_frequency`... :sweat:
   - Changing `filter_immune_slices` and `filter_immune_slice_fields` variables will touch about 6 files 20 places, it's not very relevant to the purpose of this bug fix.
   
   I would rather keep this PR simple. But in the PR involved big code refactory like #7908, i can globally change a few filter related variables naming.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org