[GitHub] [pinot] navina commented on a diff in pull request #10324: Adding table name to create unique Kafka consumer client Ids

["navina (via GitHub)" <gi...@apache.org>]

navina commented on code in PR #10324:
URL: https://github.com/apache/pinot/pull/10324#discussion_r1118945939


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,7 +63,8 @@ public Exception getException() {
   @Override
   public Boolean call()
       throws Exception {
-    String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-" + _topicName;
+    String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"

Review Comment:
   I wonder if we should also add a timestamp here since this is part of a periodic task. Shouldn't matter much as the usage here is limited to metadata lookup. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org