[GitHub] [pinot] deemoliu commented on pull request #9062: [Upsert] persist validDocsIndex snapshot for Pinot upsert optimization

[GitBox <gi...@apache.org>]

deemoliu commented on PR #9062:
URL: https://github.com/apache/pinot/pull/9062#issuecomment-1190534594

   > Is there a reason we can't enable this by default and need a config?
   
   Hi @KKcorps thanks for reviewing. I think `snapshotEnabled` can be used as a config field similiar to "nullHandlingEnabled".   It will not affect the backward compatibility.
   Also i am think about refactor this config once the TTL config is added, so it will be by default enabled for all the upsert TTL use cases (since it's required).
   
   What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org