You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by "yswdqz (via GitHub)" <gi...@apache.org> on 2023/02/06 04:16:15 UTC

[GitHub] [skywalking] yswdqz commented on pull request #10349: Change `scapedMetricsNameCache` method to support `/`

yswdqz commented on PR #10349:
URL: https://github.com/apache/skywalking/pull/10349#issuecomment-1418488630

   Initially I wanted to convert `/` to `-` but mal doesn't support `-` either.
   I also tried to write unit tests, but creating PrometheusMetricConverter object was complicated. So I have tested it locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org