You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/05/02 18:33:42 UTC

[Impala-ASF-CR] IMPALA-11253: Support testing with Java 11

Michael Smith has uploaded a new patch set (#5) to the change originally created by Joe McDonnell. ( http://gerrit.cloudera.org:8080/19539 )

Change subject: IMPALA-11253: Support testing with Java 11
......................................................................

IMPALA-11253: Support testing with Java 11

Adds new environment variable IMPALA_JDK_VERSION which can be 'system',
'8', or '11'.  The default is 'system', which uses the same logic as
before. If set to 8 or 11, it will ignore the system java and search for
java of that specific version (based on specific directories for Ubuntu
and Redhat). This is used by bin/bootstrap_system.sh to determine
whether to install java 8 or java 11 (other versions can come later). If
IMPALA_JDK_VERSION=11, then bin/start-impala-cluster.py adds the opens
needed to deal with the ehcache issue.

This no longer puts JAVA_HOME in bin/impala-config-local.sh as part of
bootstrap_system.sh. Instead, it provides a new environment variable
IMPALA_JAVA_HOME_OVERRIDE, which will be preferred over
IMPALA_JDK_VERSION.

This also updates the versions of Maven plugins related to the build.

Source and target releases are still set to Java 8 compatibility.

Adds a verifier to the end of run-all-tests that
InaccessibleObjectException is not present in impalad logs. Tested with

  JDBC_TEST=false CLUSTER_TEST=false FE_TEST=false BE_TEST=false \
    EE_TEST_FILES=observability/test_log_fragments.py run-all-tests.sh

Change-Id: I15d309e2092c12d7fdd2c99b727f3a8eed8bc07a
---
M CMakeLists.txt
M bin/bootstrap_system.sh
A bin/impala-config-java.sh
M bin/impala-config.sh
M bin/start-impala-cluster.py
D cmake_modules/FindJNI.cmake
M fe/pom.xml
M fe/src/test/java/org/apache/impala/util/JMXJsonUtilTest.java
M java/TableFlattener/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
M testdata/bin/run-mini-dfs.sh
M testdata/bin/run-ranger-server.sh
M tests/run-tests.py
A tests/verifiers/test_banned_log_messages.py
24 files changed, 216 insertions(+), 373 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/19539/5
-- 
To view, visit http://gerrit.cloudera.org:8080/19539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15d309e2092c12d7fdd2c99b727f3a8eed8bc07a
Gerrit-Change-Number: 19539
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>