You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/09 01:29:34 UTC

Re: [PR] fix(explore): prevent verbose_name from overriding column_name in filter resolution [superset]

rusackas commented on PR #38689:
URL: https://github.com/apache/superset/pull/38689#issuecomment-5594377992

   Heya, checking back in since my rebase attempt this summer. It's conflicting with `master` again and unit tests are failing. 
   
   As sadpandajoe flagged, the new tests reference `columns_by_name` as an attribute on `SqlaTable` that doesn't exist, since the real mapping lives locally in `get_sqla_query`, and there's still a gap in the metric-conflict guard that the verbose-name fallback path doesn't cover.
   
   Since the branch allows maintainer edits, I'm happy to push the rebase and the test fix here rather than start a new branch. Let me know if you'd rather take it on, otherwise we might jump in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org