You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/08/29 10:28:25 UTC
[GitHub] [spark] tisonkun opened a new pull request, #42721: Interrupt receiveLoop on MessageLoop shutdown
tisonkun opened a new pull request, #42721:
URL: https://github.com/apache/spark/pull/42721
This is spotted when I read the "send-abort" test that it waits a long time before the `RpcEnv` (-> `Dispatcher` -> `MessageLoop`) can properly stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tisonkun commented on pull request #42721: Interrupt receiveLoop on MessageLoop shutdown
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #42721:
URL: https://github.com/apache/spark/pull/42721#issuecomment-1702152336
Thank you! FYI in my fork I improve the test finish logic https://github.com/tisonkun/morax/commit/b2901ff9e26768aa5ff44ff6fc530b3c2ff4659b.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tisonkun closed pull request #42721: Interrupt receiveLoop on MessageLoop shutdown
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed pull request #42721: Interrupt receiveLoop on MessageLoop shutdown
URL: https://github.com/apache/spark/pull/42721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #42721: Interrupt receiveLoop on MessageLoop shutdown
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #42721:
URL: https://github.com/apache/spark/pull/42721#issuecomment-1702137709
We want the message loop to process all pending messages - `shutdownNow` will attempt to stop the loop immediately, which is not what we want here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org