You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Carlos Santana <cs...@gmail.com> on 2015/09/10 16:25:57 UTC
going to merge PR #39 for globalization plugin ?
Any objections for me to merge PR #39 [1] ?
I'm going to review it again, and merge if it looks good.
Also I see that there are other 5 PRs, dating back to Aug 28, 2014 ouch !!
Was thinking on giving some love to the plugin and handle the other PRs
also, what you guys think?
Anyone knows if some of these PRs are already merged, and just open can't
be close with a git comment? I'm too lazy to check :-p if someone can give
me the answer quickly
[1]: https://github.com/apache/cordova-plugin-globalization/pull/39
Re: going to merge PR #39 for globalization plugin ?
Posted by Carlos Santana <cs...@gmail.com>.
OK I'm done with cordova-plugin-globalization
No more open PRs
last open PR should close when apache git syncs
Also resolve the JIRA issues associated with the PRs
By the way, empty commit to close PRs work, give it a try again if you know
of PRs that need to be close in other repos.
On Thu, Sep 10, 2015 at 5:26 PM Carlos Santana <cs...@gmail.com> wrote:
> yup, that's what I always reference, and try to update as need it as I
> find things
>
>
> On Thu, Sep 10, 2015 at 4:42 PM Nikhil Khandelwal <ni...@microsoft.com>
> wrote:
>
>> Would be great to have some help in merging pending PRs. There are lots
>> of them pending. [1]
>>
>> This is a good guide on this for committers:
>> https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md
>>
>> Thanks,
>> Nikhil
>>
>> [1] http://s.apache.org/cordovaPulls
>>
>> -----Original Message-----
>> From: Shazron [mailto:shazron@gmail.com]
>> Sent: Thursday, September 10, 2015 11:06 AM
>> To: dev@cordova.apache.org
>> Subject: Re: going to merge PR #39 for globalization plugin ?
>>
>> I'm too lazy as well, too much to do :/ looks like you have to do it.
>> Merge it no need to ask permission, dear core committer :)
>>
>> On Thursday, September 10, 2015, Carlos Santana <cs...@gmail.com>
>> wrote:
>>
>> > Any objections for me to merge PR #39 [1] ?
>> > I'm going to review it again, and merge if it looks good.
>> >
>> > Also I see that there are other 5 PRs, dating back to Aug 28, 2014 ouch
>> !!
>> >
>> > Was thinking on giving some love to the plugin and handle the other
>> > PRs also, what you guys think?
>> >
>> > Anyone knows if some of these PRs are already merged, and just open
>> > can't be close with a git comment? I'm too lazy to check :-p if
>> > someone can give me the answer quickly
>> >
>> > [1]:
>> >
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-plugin-globalization%2fpull%2f39&data=01%7c01%7cnikhilkh%40microsoft.com%7c4f072382eacb4d1a461108d2ba0a7b52%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fZTeBpO14TWnXOsWyBIRlAhLHyAGrXSUr3TOqTNYCQk%3d
>> >
>>
>
Re: going to merge PR #39 for globalization plugin ?
Posted by Carlos Santana <cs...@gmail.com>.
yup, that's what I always reference, and try to update as need it as I find
things
On Thu, Sep 10, 2015 at 4:42 PM Nikhil Khandelwal <ni...@microsoft.com>
wrote:
> Would be great to have some help in merging pending PRs. There are lots of
> them pending. [1]
>
> This is a good guide on this for committers:
> https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md
>
> Thanks,
> Nikhil
>
> [1] http://s.apache.org/cordovaPulls
>
> -----Original Message-----
> From: Shazron [mailto:shazron@gmail.com]
> Sent: Thursday, September 10, 2015 11:06 AM
> To: dev@cordova.apache.org
> Subject: Re: going to merge PR #39 for globalization plugin ?
>
> I'm too lazy as well, too much to do :/ looks like you have to do it.
> Merge it no need to ask permission, dear core committer :)
>
> On Thursday, September 10, 2015, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > Any objections for me to merge PR #39 [1] ?
> > I'm going to review it again, and merge if it looks good.
> >
> > Also I see that there are other 5 PRs, dating back to Aug 28, 2014 ouch
> !!
> >
> > Was thinking on giving some love to the plugin and handle the other
> > PRs also, what you guys think?
> >
> > Anyone knows if some of these PRs are already merged, and just open
> > can't be close with a git comment? I'm too lazy to check :-p if
> > someone can give me the answer quickly
> >
> > [1]:
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-plugin-globalization%2fpull%2f39&data=01%7c01%7cnikhilkh%40microsoft.com%7c4f072382eacb4d1a461108d2ba0a7b52%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fZTeBpO14TWnXOsWyBIRlAhLHyAGrXSUr3TOqTNYCQk%3d
> >
>
RE: going to merge PR #39 for globalization plugin ?
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
Would be great to have some help in merging pending PRs. There are lots of them pending. [1]
This is a good guide on this for committers: https://github.com/apache/cordova-coho/blob/master/docs/processing-pull-requests.md
Thanks,
Nikhil
[1] http://s.apache.org/cordovaPulls
-----Original Message-----
From: Shazron [mailto:shazron@gmail.com]
Sent: Thursday, September 10, 2015 11:06 AM
To: dev@cordova.apache.org
Subject: Re: going to merge PR #39 for globalization plugin ?
I'm too lazy as well, too much to do :/ looks like you have to do it.
Merge it no need to ask permission, dear core committer :)
On Thursday, September 10, 2015, Carlos Santana <cs...@gmail.com>
wrote:
> Any objections for me to merge PR #39 [1] ?
> I'm going to review it again, and merge if it looks good.
>
> Also I see that there are other 5 PRs, dating back to Aug 28, 2014 ouch !!
>
> Was thinking on giving some love to the plugin and handle the other
> PRs also, what you guys think?
>
> Anyone knows if some of these PRs are already merged, and just open
> can't be close with a git comment? I'm too lazy to check :-p if
> someone can give me the answer quickly
>
> [1]:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-plugin-globalization%2fpull%2f39&data=01%7c01%7cnikhilkh%40microsoft.com%7c4f072382eacb4d1a461108d2ba0a7b52%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=fZTeBpO14TWnXOsWyBIRlAhLHyAGrXSUr3TOqTNYCQk%3d
>
Re: going to merge PR #39 for globalization plugin ?
Posted by Shazron <sh...@gmail.com>.
I'm too lazy as well, too much to do :/ looks like you have to do it.
Merge it no need to ask permission, dear core committer :)
On Thursday, September 10, 2015, Carlos Santana <cs...@gmail.com>
wrote:
> Any objections for me to merge PR #39 [1] ?
> I'm going to review it again, and merge if it looks good.
>
> Also I see that there are other 5 PRs, dating back to Aug 28, 2014 ouch !!
>
> Was thinking on giving some love to the plugin and handle the other PRs
> also, what you guys think?
>
> Anyone knows if some of these PRs are already merged, and just open can't
> be close with a git comment? I'm too lazy to check :-p if someone can give
> me the answer quickly
>
> [1]: https://github.com/apache/cordova-plugin-globalization/pull/39
>