You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by Han G <dh...@hotmail.com> on 2022/03/24 12:17:49 UTC
[TASK] Add configuration for all plugins to control if it will be loaded or not
Hi all,
Here is a proposal to add `enabled` configuration for all plugins. Like we did for metrics plugin. Related issue: https://github.com/apache/incubator-shenyu/issues/3112
[cid:image001.png@01D83FBB.CFED0180]
I plan to do the similar thing for all the plugins and set it to `enabled` by default. Below is an example.
[cid:image002.png@01D83FBB.F6D6B4D0]
Please let me know if any comment. 😊
Thanks,
Han
Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
Posted by XiaoYu <xi...@apache.org>.
hi Han
it be merged.
Thank you for your contribution~
Han G <dh...@hotmail.com> 于2022年3月25日周五 14:50写道：
>
> Thank you for your review, Yu. Yes, I’ve finished this task, here is the PR. https://github.com/apache/incubator-shenyu/pull/3116.
>
> Feel free to leave comment.
>
> Thanks,
> Han
>
>
> From: XiaoYu <xi...@apache.org>
> Date: Friday, March 25, 2022 at 11:15
> To: dev@shenyu.apache.org <de...@shenyu.apache.org>
> Subject: Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
> Hi
> this pr [1], i alreay review.
>
> You should make the most minor changes.
>
> Thank you for your contribution .
>
> [1]: https://github.com/apache/incubator-shenyu/issues/3112
>
> XiaoYu <xi...@apache.org> 于2022年3月24日周四 21:45写道：
>
> > hi
> >
> > it mybe shenyu.plugin.xxxx.enabled in Configurataion
> >
> > Han G <dh...@hotmail.com> 于2022年3月24日周四 21:12写道：
> >
> >> Here I have a question. Which name convention we should follow? E.g. for
> >> context plugin,
> >>
> >> 1. shenyu.context.enabled
> >> 2. shenyu.plugin.context.enabled
> >>
> >>
> >>
> >> Which one is better? Currently, I think we follow the #1 style, like
> >> shenyu.metrics.enabled. And I’ll follow #1 style too. Pls let me know if
> >> any suggestion.
> >>
> >>
> >>
> >> Thanks,
> >>
> >> Han
> >>
> >>
> >>
> >>
> >>
> >> *From: *Han G <dh...@hotmail.com>
> >> *Date: *Thursday, March 24, 2022 at 20:17
> >> *To: *dev@shenyu.apache.org <de...@shenyu.apache.org>
> >> *Subject: *[TASK] Add configuration for all plugins to control if it
> >> will be loaded or not
> >>
> >> Hi all,
> >>
> >>
> >>
> >> Here is a proposal to add `enabled` configuration for all plugins. Like
> >> we did for metrics plugin. Related issue:
> >> https://github.com/apache/incubator-shenyu/issues/3112
> >>
> >>
> >>
> >> I plan to do the similar thing for all the plugins and set it to
> >> `enabled` by default. Below is an example.
> >>
> >>
> >>
> >> Please let me know if any comment. 😊
> >>
> >>
> >>
> >> Thanks,
> >>
> >> Han
> >>
> >>
> >>
> >
Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
Posted by Han G <dh...@hotmail.com>.
Thank you for your review, Yu. Yes, I’ve finished this task, here is the PR. https://github.com/apache/incubator-shenyu/pull/3116.
Feel free to leave comment.
Thanks,
Han
From: XiaoYu <xi...@apache.org>
Date: Friday, March 25, 2022 at 11:15
To: dev@shenyu.apache.org <de...@shenyu.apache.org>
Subject: Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
Hi
this pr [1], i alreay review.
You should make the most minor changes.
Thank you for your contribution .
[1]: https://github.com/apache/incubator-shenyu/issues/3112
XiaoYu <xi...@apache.org> 于2022年3月24日周四 21:45写道：
> hi
>
> it mybe shenyu.plugin.xxxx.enabled in Configurataion
>
> Han G <dh...@hotmail.com> 于2022年3月24日周四 21:12写道：
>
>> Here I have a question. Which name convention we should follow? E.g. for
>> context plugin,
>>
>> 1. shenyu.context.enabled
>> 2. shenyu.plugin.context.enabled
>>
>>
>>
>> Which one is better? Currently, I think we follow the #1 style, like
>> shenyu.metrics.enabled. And I’ll follow #1 style too. Pls let me know if
>> any suggestion.
>>
>>
>>
>> Thanks,
>>
>> Han
>>
>>
>>
>>
>>
>> *From: *Han G <dh...@hotmail.com>
>> *Date: *Thursday, March 24, 2022 at 20:17
>> *To: *dev@shenyu.apache.org <de...@shenyu.apache.org>
>> *Subject: *[TASK] Add configuration for all plugins to control if it
>> will be loaded or not
>>
>> Hi all,
>>
>>
>>
>> Here is a proposal to add `enabled` configuration for all plugins. Like
>> we did for metrics plugin. Related issue:
>> https://github.com/apache/incubator-shenyu/issues/3112
>>
>>
>>
>> I plan to do the similar thing for all the plugins and set it to
>> `enabled` by default. Below is an example.
>>
>>
>>
>> Please let me know if any comment. 😊
>>
>>
>>
>> Thanks,
>>
>> Han
>>
>>
>>
>
Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
Posted by XiaoYu <xi...@apache.org>.
Hi
this pr [1], i alreay review.
You should make the most minor changes.
Thank you for your contribution .
[1]: https://github.com/apache/incubator-shenyu/issues/3112
XiaoYu <xi...@apache.org> 于2022年3月24日周四 21:45写道：
> hi
>
> it mybe shenyu.plugin.xxxx.enabled in Configurataion
>
> Han G <dh...@hotmail.com> 于2022年3月24日周四 21:12写道：
>
>> Here I have a question. Which name convention we should follow? E.g. for
>> context plugin,
>>
>> 1. shenyu.context.enabled
>> 2. shenyu.plugin.context.enabled
>>
>>
>>
>> Which one is better? Currently, I think we follow the #1 style, like
>> shenyu.metrics.enabled. And I’ll follow #1 style too. Pls let me know if
>> any suggestion.
>>
>>
>>
>> Thanks,
>>
>> Han
>>
>>
>>
>>
>>
>> *From: *Han G <dh...@hotmail.com>
>> *Date: *Thursday, March 24, 2022 at 20:17
>> *To: *dev@shenyu.apache.org <de...@shenyu.apache.org>
>> *Subject: *[TASK] Add configuration for all plugins to control if it
>> will be loaded or not
>>
>> Hi all,
>>
>>
>>
>> Here is a proposal to add `enabled` configuration for all plugins. Like
>> we did for metrics plugin. Related issue:
>> https://github.com/apache/incubator-shenyu/issues/3112
>>
>>
>>
>> I plan to do the similar thing for all the plugins and set it to
>> `enabled` by default. Below is an example.
>>
>>
>>
>> Please let me know if any comment. 😊
>>
>>
>>
>> Thanks,
>>
>> Han
>>
>>
>>
>
Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
Posted by XiaoYu <xi...@apache.org>.
hi
it mybe shenyu.plugin.xxxx.enabled in Configurataion
Han G <dh...@hotmail.com> 于2022年3月24日周四 21:12写道：
> Here I have a question. Which name convention we should follow? E.g. for
> context plugin,
>
> 1. shenyu.context.enabled
> 2. shenyu.plugin.context.enabled
>
>
>
> Which one is better? Currently, I think we follow the #1 style, like
> shenyu.metrics.enabled. And I’ll follow #1 style too. Pls let me know if
> any suggestion.
>
>
>
> Thanks,
>
> Han
>
>
>
>
>
> *From: *Han G <dh...@hotmail.com>
> *Date: *Thursday, March 24, 2022 at 20:17
> *To: *dev@shenyu.apache.org <de...@shenyu.apache.org>
> *Subject: *[TASK] Add configuration for all plugins to control if it will
> be loaded or not
>
> Hi all,
>
>
>
> Here is a proposal to add `enabled` configuration for all plugins. Like we
> did for metrics plugin. Related issue:
> https://github.com/apache/incubator-shenyu/issues/3112
>
>
>
> I plan to do the similar thing for all the plugins and set it to `enabled`
> by default. Below is an example.
>
>
>
> Please let me know if any comment. 😊
>
>
>
> Thanks,
>
> Han
>
>
>
Re: [TASK] Add configuration for all plugins to control if it will be loaded or not
Posted by Han G <dh...@hotmail.com>.
Here I have a question. Which name convention we should follow? E.g. for context plugin,
1. shenyu.context.enabled
2. shenyu.plugin.context.enabled
Which one is better? Currently, I think we follow the #1 style, like shenyu.metrics.enabled. And I’ll follow #1 style too. Pls let me know if any suggestion.
Thanks,
Han
From: Han G <dh...@hotmail.com>
Date: Thursday, March 24, 2022 at 20:17
To: dev@shenyu.apache.org <de...@shenyu.apache.org>
Subject: [TASK] Add configuration for all plugins to control if it will be loaded or not
Hi all,
Here is a proposal to add `enabled` configuration for all plugins. Like we did for metrics plugin. Related issue: https://github.com/apache/incubator-shenyu/issues/3112
[cid:image001.png@01D83FBB.CFED0180]
I plan to do the similar thing for all the plugins and set it to `enabled` by default. Below is an example.
[cid:image002.png@01D83FBB.F6D6B4D0]
Please let me know if any comment. 😊
Thanks,
Han