[GitHub] [druid] LakshSingla commented on issue #11929: Batch ingestion using SQL INSERT

[GitBox <gi...@apache.org>]

LakshSingla commented on issue #11929:
URL: https://github.com/apache/druid/issues/11929#issuecomment-1096431798

   > One nit on the `WHERE TRUE`: this won't work the way we hope. The default in SQL is `WHERE TRUE`. Calcite will optimize all trivial expressions `WHERE 1=1`, `WHERE 0=0`, etc. down to nothing, which means `WHERE TRUE`. So, we probably can't (and shouldn't) tell the difference between no `WHERE` at all and `WHERE TRUE`.
   
   @paul-rogers Calcite optimizations would be performed post the syntactical analysis. According to my understanding, we extract all the extraneous information relevant to Druid (like the segments & intervals to replace) as one of the first steps. So this optimization shouldn't be a concern, and we should be able to use `DELETE WHERE TRUE` if desirable. Please correct me if I am wrong (cc @adarshsanjeev).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org