You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/27 13:03:05 UTC

[GitHub] [pulsar] lhotari opened a new pull request #10404: [Broker] Prevent carrying state of PositionImplRecyclable when recycled

lhotari opened a new pull request #10404:
URL: https://github.com/apache/pulsar/pull/10404


   ### Motivation
   
   When reviewing the state management of some recycled instances, I came across an issue in PositionImplRecyclable where the ackSet field is not cleared when reused. It is unclear what the impact of this inconsistency is.
   PositionImplRecyclable is used in [ManagedCursorImpl's recyclePositionRangeConverter](https://github.com/apache/pulsar/blob/bbd4e5d546397c982e4eff7d7ae3440c7c2a79fb/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L162-L167). 
   
   ### Modifications
   
   - clear the ackSet field before and after reusing a PositionImplRecyclable instance.
   - add a unit test that reproduced the issue before the fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #10404: [Broker] Prevent carrying state of PositionImplRecyclable when recycled

Posted by GitBox <gi...@apache.org>.

merlimat merged pull request #10404:
URL: https://github.com/apache/pulsar/pull/10404


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org