[GitHub] brooklyn-server issue #393: Lifecycle fixes

[sjcorbett <gi...@git.apache.org>]

Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-server/pull/393
  
    One possibly surprising new behaviour from 1e44522 involves the status of a `BasicStartable` when its children restart. I'll use this blueprint as an example:
    ```yaml
    location: localhost
    services:
    - type: org.apache.brooklyn.entity.stock.BasicStartableImpl
      brooklyn.children:
      - type: org.apache.brooklyn.entity.software.base.EmptySoftwareProcess
        brooklyn.config:
          postLaunchCommand: "exit 1"
          startTimeout: 2s
    ```
    Previously, once the ESP entity has failed once the `BasicStartable` is _always_ on fire, even if `postLaunchCommand` were modified to something sensible. With the changes in this pull request when the ESP restarts the BasicStartable's state transitions to RUNNING, then back to `ON_FIRE` when the post-launch command fails for the second time. I discussed this with @justin.thompson. We felt that though the new behaviour isn't entirely satisfactory it is less wrong than before. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---