You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Eric Shu <es...@pivotal.io> on 2016/10/12 23:32:17 UTC
Review Request 52812: GEODE-1999: Fix offheap memory leak when
exception is
thrown during basicDestroy call to remove GatewaySenderEventImpl from the
sender queue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52812/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Bugs: GOEDE-1999
https://issues.apache.org/jira/browse/GOEDE-1999
Repository: geode
Description
-------
Using try and finally to make sure the offheap reference will be released.
Make similar changes for the parrellel wan queue as well.
Also release offheap memory if a virtualPut failed to put the GatewaySenderEnent into the sender queue.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractBucketRegionQueue.java 8fa8597
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java 294b616
geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java 79b9d86
Diff: https://reviews.apache.org/r/52812/diff/
Testing
-------
prechecking
Thanks,
Eric Shu
Re: Review Request 52812: GEODE-1999: Fix offheap memory leak when
exception
is thrown during basicDestroy call to remove GatewaySenderEventImpl from
the sender queue
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52812/#review152422
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Oct. 12, 2016, 4:32 p.m., Eric Shu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52812/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2016, 4:32 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Bugs: GOEDE-1999
> https://issues.apache.org/jira/browse/GOEDE-1999
>
>
> Repository: geode
>
>
> Description
> -------
>
> Using try and finally to make sure the offheap reference will be released.
> Make similar changes for the parrellel wan queue as well.
> Also release offheap memory if a virtualPut failed to put the GatewaySenderEnent into the sender queue.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractBucketRegionQueue.java 8fa8597
> geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java 294b616
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderQueue.java 79b9d86
>
> Diff: https://reviews.apache.org/r/52812/diff/
>
>
> Testing
> -------
>
> prechecking
>
>
> Thanks,
>
> Eric Shu
>
>