[BUG] What I did to Delete.java and what you didn't ;-)

[Martin van den Bemt <mv...@mvdb.com>]

Stefan,

When testing my new stuff (chmod, chown, chgrp and chrights), I came across
a bug. Because you seem to be working on this at this moment, I'm not fixing
it myself.
When you set the quiet attribute to true, if doesn't delete the directory.
If I don't touch it (default is false anyawy) I don't get the "documented'
exceptions when the directory doesn't exist....

Mvgr,
Martin van den Bemt
mvdb@mvdb.com

-----Original Message-----
From: Stefan Bodewig [mailto:bodewig@apache.org]
Sent: Friday, January 19, 2001 9:35 AM
To: ant-dev@jakarta.apache.org
Subject: Re: What I did to Delete.java


Jason Rosenberg <ja...@squaretrade.com> wrote:

> In Delete.java, when explicitly deleting a directory with verbose
> mode, you get double reporting of the "Deleting" message:
>
> Deleting directory /foo/bar/
> Deleting directory /foo/bar/

OK, this is annoying and should be addressed.

<snip/>

> And changed the logging in the removeDir() method to always happen,
> instead of just for verbose mode:

I'm not sure I'd want that much output - this is going to print a line
for every single directory out of a big directory tree. IMHO this
should be left to verbose reporting.

Others?

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: ant-dev-help@jakarta.apache.org

Re: [BUG] What I did to Delete.java and what you didn't ;-)

[Glenn McAllister <gl...@somanetworks.com>]

> > Because you seem to be working on this at this moment, I'm not
> > fixing it myself.
>
> I thought Glenn was 8-)
>

I am. :-)

I've fixed the message issue.  I've also fixed the bug with the quiet flag.
The logic was right, just in the wrong order. :-)  If quiet=true (!quiet
&& !d.delete()) expression resolves to false *before* trying the delete, so
the delete never happens.

Once ssh and cvs are back up and running, I'll check in the fix.

Glenn McAllister

RE: [BUG] What I did to Delete.java and what you didn't ;-)

[Martin van den Bemt <mv...@mvdb.com>]

I'll check out the latest version tonight and see if the problem still
exists (maby it's solved by accident) If the bug is still there, I'll fix
it...

Mvgr,
Martin

-----Original Message-----
From: Stefan Bodewig [mailto:bodewig@apache.org]
Sent: Monday, January 22, 2001 9:49 AM
To: ant-dev@jakarta.apache.org
Subject: Re: [BUG] What I did to Delete.java and what you didn't ;-)


Martin van den Bemt <mv...@mvdb.com> wrote:

> Because you seem to be working on this at this moment, I'm not
> fixing it myself.

I thought Glenn was 8-)

Anyway, I don't think I'll find time to look into your issues today,
so if you know how to fix the bug, feel free to send a patch anyway.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: ant-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: ant-dev-help@jakarta.apache.org

Re: [BUG] What I did to Delete.java and what you didn't ;-)

[Stefan Bodewig <bo...@apache.org>]

Martin van den Bemt <mv...@mvdb.com> wrote:

> Because you seem to be working on this at this moment, I'm not
> fixing it myself.

I thought Glenn was 8-)

Anyway, I don't think I'll find time to look into your issues today,
so if you know how to fix the bug, feel free to send a patch anyway.

Stefan