[GitHub] [pulsar] codelipenghui commented on a change in pull request #7266: [pulsar-broker] Dispatch batch messages according consumer permits

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #7266:
URL: https://github.com/apache/pulsar/pull/7266#discussion_r440532193



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/Entry.java
##########
@@ -65,4 +65,39 @@
      */
     boolean release();
 
+    /**
+     * Get number of batch messages into the entry.
+     * @return
+     */
+    int getNumberOfBatchMessages();
+
+    /**
+     * Set number of batch messages into the entry.
+     * @param numberOfBatchMessages
+     */
+    void setNumberOfBatchMessages(int numberOfBatchMessages);
+
+    /**
+     * Set data size of the entry.
+     * @param totalSizeInBytes
+     */
+    void setTotalSizeInBytes(int totalSizeInBytes);
+
+    /**
+     * Set total number of chunked messages in entry.
+     * @param totalChunkedMessages
+     */
+    void setTotalChunkedMessages(int totalChunkedMessages);
+
+    /**
+     * Get total data size of the entry.
+     * @return
+     */
+    int getTotalSizeInBytes();
+
+    /**
+     * Get total number of chuncked messages.
+     * @return
+     */
+    int getTotalChunkedMessages();

Review comment:
       I think we better not add message related concepts to the entry. Maybe we can add a context carrier in the entry. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org