You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/05/26 19:21:48 UTC
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9390: SAMA5D2, improve LCD support and correct minor errors
xiaoxiang781216 commented on code in PR #9390:
URL: https://github.com/apache/nuttx/pull/9390#discussion_r1207233850
##########
arch/arm/src/sama5/sam_lcd.c:
##########
@@ -3116,8 +3151,9 @@ void sam_lcdclear(nxgl_mxpixel_t color)
uint32_t *dest = (uint32_t *)LAYER_BASE.framebuffer;
int i;
- lcdinfo("Clearing display: BPP=32 color=%08x framebuffer=%08x size=%d\n",
- color, LAYER_BASE.framebuffer, SAMA5_BASE_FBSIZE);
+ lcdinfo("Clearing display: BPP=32 color=%" PRIx32 \
Review Comment:
remove \
##########
arch/arm/src/sama5/sam_lcd.c:
##########
@@ -1307,9 +1325,10 @@ static void sam_dmasetup(int lid, struct sam_dscr_s *dscr, uint8_t *buffer)
#if defined(CONFIG_DEBUG_GRAPHICS) && defined(CONFIG_DEBUG_INFO)
/* Dump the DMA setup */
- lcdinfo("DMA descriptor: addr=%08x ctrl=%08x next=%08x\n",
- dscr->addr, dscr->ctrl, dscr->next);
- lcdinfo("DMA registers[%d]: head=%08x addr=%08x ctrl=%08x next=%08x\n",
+ lcdinfo("DMA descriptor: addr=%" PRIx32 " ctrl=%" PRIx32 " next=%" \
Review Comment:
```suggestion
lcdinfo("DMA descriptor: addr=%" PRIx32 " ctrl=%" PRIx32 " next=%"
```
##########
arch/arm/src/sama5/sam_lcd.c:
##########
@@ -3099,8 +3134,8 @@ void sam_lcdclear(nxgl_mxpixel_t color)
uint8_t b;
int i;
- lcdinfo("Clearing display: BPP=24 color=%06x framebuffer=%08x size=%d\n",
- color, LAYER_BASE.framebuffer, SAMA5_BASE_FBSIZE);
+ lcdinfo("Clearing display: BPP=24 color=%" PRIx32 \
Review Comment:
remove \
##########
arch/arm/src/sama5/sam_lcd.c:
##########
@@ -1307,9 +1325,10 @@ static void sam_dmasetup(int lid, struct sam_dscr_s *dscr, uint8_t *buffer)
#if defined(CONFIG_DEBUG_GRAPHICS) && defined(CONFIG_DEBUG_INFO)
/* Dump the DMA setup */
- lcdinfo("DMA descriptor: addr=%08x ctrl=%08x next=%08x\n",
- dscr->addr, dscr->ctrl, dscr->next);
- lcdinfo("DMA registers[%d]: head=%08x addr=%08x ctrl=%08x next=%08x\n",
+ lcdinfo("DMA descriptor: addr=%" PRIx32 " ctrl=%" PRIx32 " next=%" \
+ PRIx32 "\n", dscr->addr, dscr->ctrl, dscr->next);
+ lcdinfo("DMA registers[%d]: head=%" PRIx32 " addr=%" PRIx32 " ctrl=%" \
Review Comment:
remove \
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org