You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/04/30 20:49:27 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2064: Add option to disable encryption to AESCryptoService
milleruntime opened a new pull request #2064:
URL: https://github.com/apache/accumulo/pull/2064
* Also add tests to CryptoTest
* Closes #2000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2064: Add option to disable encryption to AESCryptoService
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2064:
URL: https://github.com/apache/accumulo/pull/2064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #2064: Add option to disable encryption to AESCryptoService
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2064:
URL: https://github.com/apache/accumulo/pull/2064#discussion_r631042939
##########
File path: core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java
##########
@@ -63,6 +63,12 @@
* Example implementation of AES encryption for Accumulo
*/
public class AESCryptoService implements CryptoService {
+ // properties required for using this service
+ public static final String CRYPTO_PREFIX = "instance.crypto.opts.";
+ public static final String KEY_URI = CRYPTO_PREFIX + "key.uri";
+ // optional properties
+ // defaults to true
+ public static final String ENCRYPT_ENABLED = CRYPTO_PREFIX + "enabled";
Review comment:
Nope. Made them private in 57aa6b2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #2064: Add option to disable encryption to AESCryptoService
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #2064:
URL: https://github.com/apache/accumulo/pull/2064#discussion_r626141116
##########
File path: core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java
##########
@@ -63,6 +63,12 @@
* Example implementation of AES encryption for Accumulo
*/
public class AESCryptoService implements CryptoService {
+ // properties required for using this service
+ public static final String CRYPTO_PREFIX = "instance.crypto.opts.";
+ public static final String KEY_URI = CRYPTO_PREFIX + "key.uri";
+ // optional properties
+ // defaults to true
+ public static final String ENCRYPT_ENABLED = CRYPTO_PREFIX + "enabled";
Review comment:
They might be used in the Tests. I will check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #2064: Add option to disable encryption to AESCryptoService
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #2064:
URL: https://github.com/apache/accumulo/pull/2064#discussion_r626009470
##########
File path: core/src/main/java/org/apache/accumulo/core/spi/crypto/AESCryptoService.java
##########
@@ -63,6 +63,12 @@
* Example implementation of AES encryption for Accumulo
*/
public class AESCryptoService implements CryptoService {
+ // properties required for using this service
+ public static final String CRYPTO_PREFIX = "instance.crypto.opts.";
+ public static final String KEY_URI = CRYPTO_PREFIX + "key.uri";
+ // optional properties
+ // defaults to true
+ public static final String ENCRYPT_ENABLED = CRYPTO_PREFIX + "enabled";
Review comment:
Should these be private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org