[jira] Commented: (HARMONY-842) [classlib][nio] Refine o.a.h.tests.java.nio.channels.DatagramChannelTest

["Andrew Zhang (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/HARMONY-842?page=comments#action_12420493 ] 

Andrew Zhang commented on HARMONY-842:
--------------------------------------

Hello, 

I also noticed there are some confusing commentaries and unstable tests in DatagramChannelTest.

I'll raise a seperate JIRA to solve these problems.

Thanks!

Best regards,
Andrew

> [classlib][nio] Refine o.a.h.tests.java.nio.channels.DatagramChannelTest
> ------------------------------------------------------------------------
>
>          Key: HARMONY-842
>          URL: http://issues.apache.org/jira/browse/HARMONY-842
>      Project: Harmony
>         Type: Test

>   Components: Classlib
>     Reporter: Andrew Zhang
>  Attachments: DatagramChannelTest.diff
>
> There are several problems in o.a.h.tests.java.nio.channels.DatagramChannelTest:
> 1. System.err/out should not appear 
> 2. Many tests may not set SecurityManager in some cases, which has side-effect.
> 3. Many useless assertEquals, consider following code:
>         try {
>             assertEquals(0, this.channel1.send(writeBuf, null));
>             fail("Should throw NPE");
>         } catch (NullPointerException e) {
>             // correct
>         }
> 4. Duplicate test
> I'll upload a patch to fix these problems.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira