[GitHub] [incubator-superset] ktmud edited a comment on issue #10254: [SIP-48] Using Ant Design as our primary component library

[GitBox <gi...@apache.org>]

ktmud edited a comment on issue #10254:
URL: https://github.com/apache/incubator-superset/issues/10254#issuecomment-656782266


   I can answer 2 and 4.
   
   Antd does not come with a code editor. It recommends `react-codemirror2` and `react-monaco-editor` in their [official doc](https://ant.design/docs/react/recommendation). We don't have to replace it if we don't want to. Replacing Ace should be another topic unrelated to this SIP.
   
   Take a look at Antd's historical migration guides: [v2 to v3](https://ant.design/docs/react/migration-v4), [v3 to v4](https://github.com/ant-design/ant-design/blob/2adf8ced24da7b3cb46a3475854a83d76a98c536/CHANGELOG.en-US.md#300). I'd say the breaking changes are quite manageable. Every time they also provided `codemod` tools to make migration easier.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org