[GitHub] maropu commented on a change in pull request #23873: [SPARK-26975][SQL] Support nested-column pruning over limit/sample/repartition

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #23873: [SPARK-26975][SQL] Support nested-column pruning over limit/sample/repartition
URL: https://github.com/apache/spark/pull/23873#discussion_r260558271
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -651,6 +651,10 @@ object ColumnPruning extends Rule[LogicalPlan] {
     // Can't prune the columns on LeafNode
     case p @ Project(_, _: LeafNode) => p
 
+    case p @ NestedColumnPruning(prunedNestedAttrs, projectsOnPrunedNestedAttrs)
 
 Review comment:
   How about defining this rule outside the existing ColumnPruning? I feel this addition makes ColumnPruning more complicated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org