You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/26 02:37:41 UTC

[GitHub] [spark] HyukjinKwon edited a comment on pull request #29421: [SPARK-32388][SQL] TRANSFORM with schema-less mode should keep the same with hive

HyukjinKwon edited a comment on pull request #29421:
URL: https://github.com/apache/spark/pull/29421#issuecomment-716270048


   Ooops, @AngersZhuuuu, seems like it has a bit of conflicts with https://github.com/apache/spark/commit/a127387a53e1a24e76de83c5a1858fcdbd38c3a2#diff-3788b2d136cabc009f0a64db207d0ffbe777c5e7ad02d5f3aa9de33e1f295843. I just realised that the last test was triggered a month before:
   
   ```
   Error:  /__w/spark/spark/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala:185:13: not found: value decimalToString
   Error:              decimalToString('d),
   Error:              ^
   Error:  /__w/spark/spark/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationSuite.scala:241:13: not found: value decimalToString
   Error:              decimalToString('d),
   Error:              ^
   ```
   
   I could just fix it right away but let's just revert it to be safer given that the test has to run against the latest upstream + Hive 1.2 path was removed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org