You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/12/06 00:21:57 UTC

[GitHub] [tvm] vinx13 opened a new pull request, #13554: [TIR] Fix layout free annotation in CreatePrimFunc

vinx13 opened a new pull request, #13554:
URL: https://github.com/apache/tvm/pull/13554

   This PR fixed missing handling of block annotations in data type rewriter.
   
   cc @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 commented on pull request #13554: [TIR] Fix layout free annotation in CreatePrimFunc

Posted by GitBox <gi...@apache.org>.
vinx13 commented on PR #13554:
URL: https://github.com/apache/tvm/pull/13554#issuecomment-1339767964

   block annotations may contain buffers that are rewritten in this pass, but it forgot to visit block annotations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #13554: [TIR] Fix layout free annotation in CreatePrimFunc

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13554:
URL: https://github.com/apache/tvm/pull/13554#issuecomment-1338742636

   Hmm I don't have a clear idea of what the issue could be. Would you like to elaborate? Thanks in advance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #13554: [TIR] Fix layout free annotation in CreatePrimFunc

Posted by GitBox <gi...@apache.org>.
junrushao merged PR #13554:
URL: https://github.com/apache/tvm/pull/13554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13554: [TIR] Fix layout free annotation in CreatePrimFunc

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13554:
URL: https://github.com/apache/tvm/pull/13554#issuecomment-1338477756

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #13554: [TIR] Fix layout free annotation in CreatePrimFunc

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13554:
URL: https://github.com/apache/tvm/pull/13554#issuecomment-1339769350

   I see. That makes sense!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org