You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/01/10 00:23:10 UTC

Re: Review Request 71935: Added a new task status reason.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71935/
-----------------------------------------------------------

(Updated Jan. 10, 2020, 12:23 a.m.)


Review request for mesos, Andrei Budnik and Qian Zhang.


Bugs: MESOS-10049
    https://issues.apache.org/jira/browse/MESOS-10049


Repository: mesos


Description
-------

The new reason will be sent to frameworks when one of their tasks is
OOM-killed on an agent while the task is exceeding its memory request.


Diffs (updated)
-----

  include/mesos/mesos.proto b0f590545df720df644d049e9d8f1e81bdbe814c 
  include/mesos/v1/mesos.proto 53a7b9bc6190d826868a1633c11c9a0ecf9acf0a 


Diff: https://reviews.apache.org/r/71935/diff/2/

Changes: https://reviews.apache.org/r/71935/diff/1-2/


Testing
-------

`make`


Thanks,

Greg Mann


Re: Review Request 71935: Added a new task status reason.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71935/#review219199
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71935]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 10, 2020, 12:23 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71935/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2020, 12:23 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10049
>     https://issues.apache.org/jira/browse/MESOS-10049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new reason will be sent to frameworks when one of their tasks is
> OOM-killed on an agent while the task is exceeding its memory request.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b0f590545df720df644d049e9d8f1e81bdbe814c 
>   include/mesos/v1/mesos.proto 53a7b9bc6190d826868a1633c11c9a0ecf9acf0a 
> 
> 
> Diff: https://reviews.apache.org/r/71935/diff/2/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 71935: Added a new task status reason.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71935/#review219221
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Jan. 10, 2020, 8:23 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71935/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2020, 8:23 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10049
>     https://issues.apache.org/jira/browse/MESOS-10049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new reason will be sent to frameworks when one of their tasks is
> OOM-killed on an agent while the task is exceeding its memory request.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto b0f590545df720df644d049e9d8f1e81bdbe814c 
>   include/mesos/v1/mesos.proto 53a7b9bc6190d826868a1633c11c9a0ecf9acf0a 
> 
> 
> Diff: https://reviews.apache.org/r/71935/diff/2/
> 
> 
> Testing
> -------
> 
> `make`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>