You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/04 23:59:45 UTC

[GitHub] [arrow] ksuarez1423 opened a new issue, #15199: [C++][Substrait] Allow AGGREGATION_INVOCATION_UNSPECIFIED as valid invocation in Substrait plan

ksuarez1423 opened a new issue, #15199:
URL: https://github.com/apache/arrow/issues/15199

   ### Describe the enhancement requested
   
   In the Substrait spec, unspecified invocations are read as AGGREGATION_INVOCATION_UNSPECIFIED, and treated as AGGREGATION_INVOCATION_ALL in practice (see: https://github.com/substrait-io/substrait/blob/main/proto/substrait/algebra.proto#L1221-L1230). Arrow's current implementation only accepts plans explicitly using AGGREGATION_INVOCATION_ALL, thus excluding valid plans using AGGREGATION_INVOCATION_UNSPECIFIED. 
   
   In order to match the expected behavior, AGGREGATION_INVOCATION_UNSPECIFIED should lead to interpretation as AGGREGATION_INVOCATION_ALL. This will allow acceptance of plans from at least the Substrait producer Ibis, which does not specify this setting.
   
   
   ### Component(s)
   
   C++, Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] westonpace closed issue #15199: [C++][Substrait] Allow AGGREGATION_INVOCATION_UNSPECIFIED as valid invocation in Substrait plan

Posted by GitBox <gi...@apache.org>.
westonpace closed issue #15199: [C++][Substrait] Allow AGGREGATION_INVOCATION_UNSPECIFIED as valid invocation in Substrait plan
URL: https://github.com/apache/arrow/issues/15199


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org