You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/05/12 19:55:12 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #14840: [TVMScript] Print Executor, Runtime, and FunctionInfo as metadata

Lunderberg opened a new pull request, #14840:
URL: https://github.com/apache/tvm/pull/14840

   Instances of `relay::Executor`, `relay::Runtime`, and `relay::backend::FunctionInfo` may be inserted into a PrimFunc's attributes for bookkeeping purposes.  In these flows, the function should still be able to be printed for debugging purposes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #14840: [TVMScript] Print Executor, Runtime, and FunctionInfo as metadata

Posted by "junrushao (via GitHub)" <gi...@apache.org>.

junrushao merged PR #14840:
URL: https://github.com/apache/tvm/pull/14840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14840: [TVMScript] Print Executor, Runtime, and FunctionInfo as metadata

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.

tvm-bot commented on PR #14840:
URL: https://github.com/apache/tvm/pull/14840#issuecomment-1546218131

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #14840: [TVMScript] Print Executor, Runtime, and FunctionInfo as metadata

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.

Lunderberg commented on PR #14840:
URL: https://github.com/apache/tvm/pull/14840#issuecomment-1547822612

   That makes sense, and agreed that it doesn't make sense to pull in portions that aren't maintained.  This mainly arose while debugging some CI failures in https://github.com/apache/tvm/pull/14778, where these types being used as attributes caused some debug print statements to fail.
   
   Maybe it would be better to have a fallback catch-all that prints the type?  That way, we avoid the relay dependency, but can still print the portions that are maintained.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org